[GRASS-QA] GRASS QA: martinl | ./grass6/lib/vector/Vlib/line.c |2
clones ( curses.c graphics.c mouse.c signature.c plot.c
main.c main.c main.c main.c main.c main.c graphics.c
graphics.c graphics.c graphics.c graphics.c c_update.c
d_drop_index.c d_drop_tab.c list.c raster_rgb.c raster_rgb.c
raster_rgb.c raster_rgb.c Get_location.c com_proto.c
com_proto.c com_proto.c loc_proto.c loc_proto.c loc_proto.c
i_face.c main.c main.c level_two.c main.c build.c line.c )| 1
monsters | 2 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Thu Mar 1 19:38:35 EST 2007
Hello martinl,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/vector/Vlib/line.c functions
Vect_new_line_struct (Begins at: 35 Ends at: 43)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect__new_line_struct (Begins at: 46 Ends at: 60)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_destroy_line_struct (Begins at: 69 Ends at: 90)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_copy_xyz_to_pnts (Begins at: 93 Ends at: 123)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 1 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_reset_line (Begins at: 126 Ends at: 140)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_append_point (Begins at: 143 Ends at: 165)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_line_insert_point (Begins at: 168 Ends at: 196)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 2 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_line_delete_point (Begins at: 199 Ends at: 217)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 19 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_line_prune (Begins at: 226 Ends at: 246)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_line_prune_thresh (Begins at: 255 Ends at: 275)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 21 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_append_points (Begins at: 278 Ends at: 315)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_copy_pnts_to_xyz (Begins at: 318 Ends at: 352)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 5 | * | |
CalledNBR: | 0 | | OK |
LOC: | 35 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_point_on_line (Begins at: 355 Ends at: 442)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 12 | | OK |
LOC: | 88 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
Vect_line_segment (Begins at: 445 Ends at: 487)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 10 | | OK |
LOC: | 43 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_line_length (Begins at: 496 Ends at: 518)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_line_geodesic_length (Begins at: 521 Ends at: 564)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 44 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_line_distance (Begins at: 567 Ends at: 663)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 11 | *** | MONSTER |
CalledNBR: | 8 | | OK |
LOC: | 97 | | OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
Vect_points_distance (Begins at: 666 Ends at: 683)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 7 | ** | Warning |
CalledNBR: | 3 | | OK |
LOC: | 18 | | OK |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
Vect_line_box (Begins at: 692 Ends at: 696)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 5 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_line_reverse (Begins at: 704 Ends at: 732)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_get_line_cat (Begins at: 735 Ends at: 748)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
Vect__new_line_struct Vect_new_line_struct
In lib/vector/Vlib/line.c clones of Vect_new_line_struct are:
lib/vector/Vlib/cats.c Vect_new_cats_struct
In lib/vector/Vlib/line.c clones of Vect__new_line_struct are:
lib/vector/Vlib/cats.c Vect__new_cats_struct
__________________________________________
Threshold GRASS6 key metrics values at 2007-03-01 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 8 |
CalledNBR: 10 | 60 | 86 |
LOC: 42 | 190 | 265 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list