[GRASS-QA] GRASS QA: hamish | ./grass6/raster/r.profile/main.c |1 clones ( curses.c graphics.c mouse.c signature.c plot.c main.c main.c main.c main.c main.c main.c graphics.c graphics.c graphics.c graphics.c graphics.c c_update.c d_drop_index.c d_drop_tab.c list.c raster_rgb.c raster_rgb.c raster_rgb.c raster_rgb.c Get_location.c com_proto.c com_proto.c com_proto.c loc_proto.c loc_proto.c loc_proto.c i_face.c main.c )| 2 monsters | 0 warnings

grass-qa at proxy.soccerlab.polymtl.ca grass-qa at proxy.soccerlab.polymtl.ca
Thu Mar 1 19:38:31 EST 2007



Hello hamish,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


raster/r.profile/main.c functions


main (Begins at: 25 Ends at: 279)
--------------+---------+-------+---------+
Complexity:   |      23 |     * |         |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |     101 |   *** | MONSTER |
LOC:          |     255 |    ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

do_profile (Begins at: 283 Ends at: 385)
--------------+---------+-------+---------+
Complexity:   |      18 |     * |         |
ParamNBR:     |      11 |   *** | MONSTER |
CalledNBR:    |      27 |       |      OK |
LOC:          |     103 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

move (Begins at: 387 Ends at: 392)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |       6 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

cont (Begins at: 394 Ends at: 415)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      22 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 1 potentially cloned functions:
  cont

In raster/r.profile/main.c clones of  cont are:
	display/d.nviz/main.c  cont


__________________________________________

Threshold GRASS6 key metrics values at 2007-03-01 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html




More information about the grass-qa mailing list