[GRASS-QA] GRASS QA: glynn | ./grass6/vector/v.digit/attr.c |no clones | 0 monsters | 1 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello glynn,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/v.digit/attr.c functions


del_cat (Begins at: 18 Ends at: 49)
--------------+---------+-------+---------+
Complexity:   |       3 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      32 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

add_cat (Begins at: 51 Ends at: 92)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       3 |       |      OK |
CalledNBR:    |      16 |       |      OK |
LOC:          |      42 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

new_record (Begins at: 100 Ends at: 155)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      21 |       |      OK |
LOC:          |      56 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

display_cats (Begins at: 159 Ends at: 243)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      37 |     * |         |
LOC:          |      85 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

copy_cats (Begins at: 246 Ends at: 368)
--------------+---------+-------+---------+
Complexity:   |      19 |     * |         |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      47 |     * |         |
LOC:          |     123 |     * |         |
--------------+---------+-------+---------+
metrics are OK

display_attributes (Begins at: 371 Ends at: 497)
--------------+---------+-------+---------+
Complexity:   |      10 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      64 |    ** | Warning |
LOC:          |     127 |     * |         |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code

check_record (Begins at: 504 Ends at: 570)
--------------+---------+-------+---------+
Complexity:   |       9 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      27 |       |      OK |
LOC:          |      67 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-03-01 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       8 |
CalledNBR:              10 |        60 |      86 |
LOC:                    42 |       190 |     265 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html