[GRASS-QA] GRASS QA: hamish | ./grass6/lib/gis/parser.c |no clones
| 1 monsters | 9 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Thu May 10 03:28:08 EDT 2007
Hello hamish,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/gis/parser.c functions
G_disable_interactive (Begins at: 160 Ends at: 181)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 22 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_define_flag (Begins at: 184 Ends at: 242)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 59 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_define_option (Begins at: 245 Ends at: 327)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 83 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_define_standard_option (Begins at: 330 Ends at: 579)
--------------+---------+-------+---------+
Complexity: | 29 | ** | Warning |
ParamNBR: | 1 | | OK |
CalledNBR: | 32 | | OK |
LOC: | 250 | ** | Warning |
--------------+---------+-------+---------+
at least 2 values are close to an outlier please consider revising code
G_define_module (Begins at: 582 Ends at: 634)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 53 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_parser (Begins at: 636 Ends at: 901)
--------------+---------+-------+---------+
Complexity: | 37 | *** | MONSTER |
ParamNBR: | 2 | | OK |
CalledNBR: | 74 | ** | Warning |
LOC: | 266 | ** | Warning |
--------------+---------+-------+---------+
at least 3 values are close to an outlier please consider revising code
uses_new_gisprompt (Begins at: 904 Ends at: 954)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 51 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_usage (Begins at: 956 Ends at: 1142)
--------------+---------+-------+---------+
Complexity: | 33 | ** | Warning |
ParamNBR: | 1 | | OK |
CalledNBR: | 53 | * | |
LOC: | 187 | * | |
--------------+---------+-------+---------+
at least 1 values are close to an outlier please consider revising code
print_escaped_for_xml (Begins at: 1144 Ends at: 1160)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 17 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_usage_xml (Begins at: 1162 Ends at: 1376)
--------------+---------+-------+---------+
Complexity: | 28 | ** | Warning |
ParamNBR: | 1 | | OK |
CalledNBR: | 71 | ** | Warning |
LOC: | 215 | ** | Warning |
--------------+---------+-------+---------+
at least 3 values are close to an outlier please consider revising code
G_usage_html (Begins at: 1378 Ends at: 1609)
--------------+---------+-------+---------+
Complexity: | 43 | *** | MONSTER |
ParamNBR: | 1 | | OK |
CalledNBR: | 78 | ** | Warning |
LOC: | 232 | ** | Warning |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!
G_script (Begins at: 1611 Ends at: 1722)
--------------+---------+-------+---------+
Complexity: | 22 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 46 | * | |
LOC: | 112 | | OK |
--------------+---------+-------+---------+
metrics are OK
generate_tcl (Begins at: 1724 Ends at: 1810)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 34 | | OK |
LOC: | 87 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_gui (Begins at: 1813 Ends at: 1842)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 8 | | OK |
LOC: | 30 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_tcltk (Begins at: 1845 Ends at: 1860)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 16 | | OK |
--------------+---------+-------+---------+
metrics are OK
show_options (Begins at: 1862 Ends at: 1892)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
show (Begins at: 1894 Ends at: 1907)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 14 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_flag (Begins at: 1909 Ends at: 1936)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
contains (Begins at: 1941 Ends at: 1950)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
set_option (Begins at: 1952 Ends at: 2012)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 61 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_opts (Begins at: 2014 Ends at: 2051)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 38 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_an_opt (Begins at: 2053 Ends at: 2095)
--------------+---------+-------+---------+
Complexity: | 10 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 43 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_int (Begins at: 2097 Ends at: 2163)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 67 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_double (Begins at: 2165 Ends at: 2205)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 41 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_string (Begins at: 2207 Ends at: 2234)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 6 | | OK |
LOC: | 28 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_required (Begins at: 2236 Ends at: 2259)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
split_opts (Begins at: 2261 Ends at: 2324)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 64 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_multiple_opts (Begins at: 2326 Ends at: 2364)
--------------+---------+-------+---------+
Complexity: | 6 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 5 | | OK |
LOC: | 39 | | OK |
--------------+---------+-------+---------+
metrics are OK
check_overwrite (Begins at: 2367 Ends at: 2423)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 11 | | OK |
LOC: | 57 | | OK |
--------------+---------+-------+---------+
metrics are OK
interactive (Begins at: 2425 Ends at: 2453)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 29 | | OK |
--------------+---------+-------+---------+
metrics are OK
interactive_flag (Begins at: 2455 Ends at: 2463)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 4 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
interactive_option (Begins at: 2465 Ends at: 2555)
--------------+---------+-------+---------+
Complexity: | 23 | * | |
ParamNBR: | 1 | | OK |
CalledNBR: | 41 | * | |
LOC: | 91 | | OK |
--------------+---------+-------+---------+
metrics are OK
split_gisprompt (Begins at: 2557 Ends at: 2587)
--------------+---------+-------+---------+
Complexity: | 4 | | OK |
ParamNBR: | 4 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 31 | | OK |
--------------+---------+-------+---------+
metrics are OK
gis_prompt (Begins at: 2589 Ends at: 2646)
--------------+---------+-------+---------+
Complexity: | 11 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 20 | | OK |
LOC: | 58 | | OK |
--------------+---------+-------+---------+
metrics are OK
G_recreate_command (Begins at: 2648 Ends at: 2750)
--------------+---------+-------+---------+
Complexity: | 13 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 25 | | OK |
LOC: | 103 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
__________________________________________
Threshold GRASS6 key metrics values at 2007-05-10 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 87 |
LOC: 43 | 195 | 273 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list