[GRASS-QA] GRASS QA: markus | ./grass6/imagery/i.vpoints/digit.c |3 clones ( curses.c signature.c curses.c curses.c digit.c curses.c digit.c curses.c digit.c )| 0 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello markus,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


imagery/i.vpoints/digit.c functions


setup_digitizer (Begins at: 10 Ends at: 45)
--------------+---------+-------+---------+
Complexity:   |       4 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      36 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

setup (Begins at: 47 Ends at: 65)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       7 |       |      OK |
LOC:          |      19 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

digitizer_point (Begins at: 67 Ends at: 101)
--------------+---------+-------+---------+
Complexity:   |       5 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      13 |       |      OK |
LOC:          |      35 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

oops (Begins at: 103 Ends at: 109)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       2 |       |      OK |
LOC:          |       7 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

no (Begins at: 111 Ends at: 115)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

yes (Begins at: 117 Ends at: 121)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       0 |       |      OK |
LOC:          |       5 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file has 3 potentially cloned functions:
  setup_digitizer  setup  digitizer_point

In imagery/i.vpoints/digit.c clones of  digitizer_point are:
	imagery/i.points/digit.c  digitizer_point
	imagery/i.ortho.photo/photo.2target/digit.c  digitizer_point

In imagery/i.vpoints/digit.c clones of  setup are:
	imagery/i.points/digit.c  setup
	imagery/i.ortho.photo/photo.2target/digit.c  setup

In imagery/i.vpoints/digit.c clones of  setup_digitizer are:
	imagery/i.points/digit.c  setup_digitizer
	imagery/i.ortho.photo/photo.2target/digit.c  setup_digitizer


__________________________________________

Threshold GRASS6 key metrics values at 2007-05-16 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      87 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html