[GRASS-QA] GRASS QA: martinl | ./grass6/lib/vector/Vlib/cats.c |2
clones ( cats.c )| 0 monsters | 0 warnings
grass-qa at proxy.soccerlab.polymtl.ca
grass-qa at proxy.soccerlab.polymtl.ca
Wed Oct 10 07:51:12 EDT 2007
Hello martinl,
here a report on your recent GRASS-CVS change:
ANALYSIS
your changes to files/functions:
lib/vector/Vlib/cats.c functions
Vect_new_cats_struct (Begins at: 37 Ends at: 45)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 9 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect__new_cats_struct (Begins at: 48 Ends at: 62)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 15 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_destroy_cats_struct (Begins at: 71 Ends at: 95)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 25 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_cat_set (Begins at: 98 Ends at: 143)
--------------+---------+-------+---------+
Complexity: | 5 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 2 | | OK |
LOC: | 46 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_cat_get (Begins at: 146 Ends at: 177)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_cat_del (Begins at: 180 Ends at: 212)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 33 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_field_cat_del (Begins at: 215 Ends at: 246)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_reset_cats (Begins at: 249 Ends at: 254)
--------------+---------+-------+---------+
Complexity: | 1 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 6 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_new_cat_list (Begins at: 263 Ends at: 286)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 0 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 24 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_destroy_cat_list (Begins at: 289 Ends at: 311)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 1 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 23 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_str_to_cat_list (Begins at: 314 Ends at: 384)
--------------+---------+-------+---------+
Complexity: | 8 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 13 | | OK |
LOC: | 71 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_array_to_cat_list (Begins at: 393 Ends at: 424)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 3 | | OK |
LOC: | 32 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_cat_in_cat_list (Begins at: 433 Ends at: 442)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 10 | | OK |
--------------+---------+-------+---------+
metrics are OK
Vect_cat_in_array (Begins at: 451 Ends at: 461)
--------------+---------+-------+---------+
Complexity: | 2 | | OK |
ParamNBR: | 3 | | OK |
CalledNBR: | 1 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
cmp (Begins at: 464 Ends at: 474)
--------------+---------+-------+---------+
Complexity: | 3 | | OK |
ParamNBR: | 2 | | OK |
CalledNBR: | 0 | | OK |
LOC: | 11 | | OK |
--------------+---------+-------+---------+
metrics are OK
Clone analysis:
This file has 2 potentially cloned functions:
Vect_new_cats_struct Vect__new_cats_struct
In lib/vector/Vlib/cats.c clones of Vect__new_cats_struct are:
lib/vector/Vlib/line.c Vect__new_line_struct
In lib/vector/Vlib/cats.c clones of Vect_new_cats_struct are:
lib/vector/Vlib/line.c Vect_new_line_struct
__________________________________________
Threshold GRASS6 key metrics values at 2007-10-10 are:
---------------------------+-----------+---------+
median | upper | outlier |
| quartile | limit |
---------------------------+-----------+---------+
Complexity (Cyclo): 5 | 25 | 37 |
ParamNBR: 2 | 6 | 9 |
CalledNBR: 10 | 60 | 88 |
LOC: 43 | 195 | 273 |
---------------------------+-----------+---------+
Measures (see below Web page for details):
Complexity (Cyclo): a complexity index
ParamNBR: number of passed parameters
CalledNBR: number of called functions
LOC: Lines Of Code
Message interpretation:
OK : Nothing to say at all
* : above 75 % of value warning
** : this is getting close to be out of range, consider revising the code
***: this is a monster, definitely you should revise this function
__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list