[GRASS-QA] GRASS QA: robertoa | ./grass6/vector/lidar/v.lidar.edgedetection/edgedetection.c |no clones | 2 monsters | 0 warnings

[grass-qa at proxy.soccerlab.polymtl.ca]

Hello robertoa,

here a report on your recent GRASS-CVS change:

ANALYSIS

your changes to files/functions:


vector/lidar/v.lidar.edgedetection/edgedetection.c functions


edge_detection (Begins at: 35 Ends at: 113)
--------------+---------+-------+---------+
Complexity:   |       7 |       |      OK |
ParamNBR:     |      10 |   *** | MONSTER |
CalledNBR:    |      32 |       |      OK |
LOC:          |      79 |       |      OK |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

Get_Gradient (Begins at: 115 Ends at: 137)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       1 |       |      OK |
LOC:          |      23 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

classification (Begins at: 139 Ends at: 309)
--------------+---------+-------+---------+
Complexity:   |      24 |     * |         |
ParamNBR:     |      16 |   *** | MONSTER |
CalledNBR:    |      61 |    ** | Warning |
LOC:          |     171 |     * |         |
--------------+---------+-------+---------+
1 metric are OUT OF RANGE!

Insert (Begins at: 311 Ends at: 324)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       6 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Insert_Interpolation (Begins at: 326 Ends at: 339)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       4 |       |      OK |
CalledNBR:    |       6 |       |      OK |
LOC:          |      14 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

UpDate (Begins at: 342 Ends at: 354)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |       4 |       |      OK |
LOC:          |      13 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Select (Begins at: 356 Ends at: 398)
--------------+---------+-------+---------+
Complexity:   |       6 |       |      OK |
ParamNBR:     |       5 |     * |         |
CalledNBR:    |      22 |       |      OK |
LOC:          |      43 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Create_AuxEdge_Table (Begins at: 401 Ends at: 434)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |      18 |       |      OK |
LOC:          |      34 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Drop_Aux_Table (Begins at: 436 Ends at: 445)
--------------+---------+-------+---------+
Complexity:   |       1 |       |      OK |
ParamNBR:     |       1 |       |      OK |
CalledNBR:    |       4 |       |      OK |
LOC:          |      10 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Create_Interpolation_Table (Begins at: 448 Ends at: 474)
--------------+---------+-------+---------+
Complexity:   |       2 |       |      OK |
ParamNBR:     |       2 |       |      OK |
CalledNBR:    |      14 |       |      OK |
LOC:          |      27 |       |      OK |
--------------+---------+-------+---------+
metrics are OK

Clone analysis:

This file does not contain  cloned functions

__________________________________________

Threshold GRASS6 key metrics values at 2007-10-19 are:
---------------------------+-----------+---------+
                    median | upper     | outlier |
                           | quartile  | limit   |
---------------------------+-----------+---------+
Complexity (Cyclo):      5 |        25 |      37 |
ParamNBR:                2 |         6 |       9 |
CalledNBR:              10 |        60 |      88 |
LOC:                    43 |       195 |     273 |
---------------------------+-----------+---------+

Measures (see below Web page for details):
 Complexity (Cyclo): a complexity index
 ParamNBR: number of passed parameters
 CalledNBR: number of called functions
 LOC: Lines Of Code

Message interpretation:
 OK : Nothing to say at all
 *  : above 75 % of value warning
 ** : this is getting close to be out of range, consider revising the code
 ***: this is a monster, definitely you should revise this function


__________________________________________
Brought to you by:
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html