# [GRASS-QA] GRASS QA: glynn |main.c main.c main.c main.c ...| 6 clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Thu Dec 11 02:20:59 EST 2008

```Hello glynn,

here's a report on your recent GRASS-SVN change :

ANALYSIS

*****************************************************************
File :grass/trunk/raster/r.flow/main.c
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

calculate(Begins at: 300, Ends at:399)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |     * |      WARNING |         8 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      30 |    ** | BABY-MONSTER |        30 |
LOC:          |     100 |    ** | BABY-MONSTER |       100 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

height_angle_bounding_box(Begins at: 94, Ends at:136)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      10 |     * |      WARNING |        10 |
LOC:          |      43 |     * |      WARNING |        43 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!

main(Begins at: 401, Ends at:592)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        13 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      71 |   *** |      MONSTER |        73 |
LOC:          |     192 |   *** |      MONSTER |       194 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

next_point(Begins at: 198, Ends at:294)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      10 |     * |      WARNING |        10 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      14 |     * |      WARNING |        14 |
LOC:          |      97 |    ** | BABY-MONSTER |        97 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

on_map(Begins at: 147, Ends at:153)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |       7 |       |           OK |         7 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!

rectify(Begins at: 172, Ends at:189)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      18 |       |           OK |        18 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
File :grass/trunk/raster/r.resamp.rst/main.c
*****************************************************************

Function
clean(Begins at: 577, Ends at:592)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |     * |      WARNING |        13 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      12 |     * |      WARNING |        12 |
LOC:          |      16 |       |           OK |        16 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!

clean_fatal_error(Begins at: 696, Ends at:723)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |       |           OK |         7 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      13 |       |           OK |        13 |
LOC:          |      28 |       |           OK |        28 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

create_temp_file(Begins at: 541, Ends at:563)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |   *** |      MONSTER |         5 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       9 |   *** |      MONSTER |         9 |
LOC:          |      23 |   *** |      MONSTER |        23 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

create_temp_files(Begins at: 565, Ends at:575)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |    ** | BABY-MONSTER |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       8 |     * |      WARNING |         8 |
LOC:          |      11 |       |           OK |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

main(Begins at: 123, Ends at:539)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      44 |       |           OK |        45 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     167 |       |           OK |       169 |
LOC:          |     417 |       |           OK |       418 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

Clone analysis:
This file does not contain cloned functions

*****************************************************************
File :grass/trunk/raster/r.sun/main.c
*****************************************************************

Function
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      28 |       |           OK |        28 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

calculate(Begins at: 1192, Ends at:1468)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      47 |   *** |      MONSTER |        47 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      71 |   *** |      MONSTER |        71 |
LOC:          |     277 |   *** |      MONSTER |       277 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

com_declin(Begins at: 1482, Ends at:1492)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      11 |       |           OK |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

com_par(Begins at: 865, Ends at:936)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |     * |      WARNING |         8 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      17 |     * |      WARNING |        17 |
LOC:          |      72 |     * |      WARNING |        72 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!

com_par_const(Begins at: 825, Ends at:862)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      38 |       |           OK |        38 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!

com_sol_const(Begins at: 1470, Ends at:1479)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

cube(Begins at: 1153, Ends at:1158)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |       6 |       |           OK |         6 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

distance(Begins at: 140, Ends at:149)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!

--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |     * |      WARNING |         8 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      55 |     * |      WARNING |        55 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!

INPUT(Begins at: 494, Ends at:690)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      47 |   *** |      MONSTER |        47 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      74 |   *** |      MONSTER |        74 |
LOC:          |     197 |   *** |      MONSTER |       197 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

joules2(Begins at: 980, Ends at:1110)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      22 |   *** |      MONSTER |        22 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      11 |     * |      WARNING |        11 |
LOC:          |     131 |    ** | BABY-MONSTER |       131 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

lumcline2(Begins at: 940, Ends at:978)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      39 |       |           OK |        39 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!

main(Begins at: 152, Ends at:491)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      21 |   *** |      MONSTER |        22 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     109 |   *** |      MONSTER |       110 |
LOC:          |     340 |   *** |      MONSTER |       341 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

new_point(Begins at: 1115, Ends at:1124)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

OUTGR(Begins at: 692, Ends at:822)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      35 |   *** |      MONSTER |        35 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      50 |   *** |      MONSTER |        50 |
LOC:          |     131 |    ** | BABY-MONSTER |       131 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

searching(Begins at: 1160, Ends at:1186)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      27 |       |           OK |        27 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!

test(Begins at: 1579, Ends at:1593)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      15 |       |           OK |        15 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

where_is_point(Begins at: 1126, Ends at:1151)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      26 |       |           OK |        26 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

Clone analysis:
This file has 6 potentially cloned functions:
distance  distance  distance  test  test

In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.sun/main.c clones of distance are:

In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.sun/main.c clones of test are:

*****************************************************************
File :grass/trunk/vector/v.surf.rst/main.c
*****************************************************************

Function
clean_fatal_error(Begins at: 848, Ends at:875)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      13 |     * |      WARNING |        13 |
LOC:          |      28 |       |           OK |        28 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!

main(Begins at: 129, Ends at:802)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      99 |   *** |      MONSTER |        99 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     291 |   *** |      MONSTER |       291 |
LOC:          |     674 |   *** |      MONSTER |       674 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

print_tree(Begins at: 806, Ends at:844)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      39 |       |           OK |        39 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!

Clone analysis:
This file does not contain cloned functions

*****************************************************************
File :grass/trunk/vector/v.vol.rst/main.c
*****************************************************************

Function
main(Begins at: 194, Ends at:910)
--------------+---------+-------+--------------+-----------+
|          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |     102 |   *** |      MONSTER |       102 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     310 |   *** |      MONSTER |       310 |
LOC:          |     717 |   *** |      MONSTER |       717 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metric are OUT OF RANGE!

Clone analysis:
This file does not contain cloned functions

____________________________________________

Threshold grass key metrics values at Thu Dec 11 02:47:06 EST 2008 are:
----------------------+-----------+-----------+-----------+
| warning   | middle    | extrem    |
| limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+

Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
OK : Nothing to say at all
*  : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function

Conclusion interpretation :
CORRECT     : if all metrics are situated before warning limits
WARNING     : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS    : if 1 to more metrics are in the extreme limits

_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory