[GRASS-QA] GRASS QA: martinl |break.c main.c | 2 clones | 0 monsters |0 warnings

[soccerlab.info at gmail.com]

Hello martinl,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/branches/develbranch_6/lib/vector/vedit/break.c
*****************************************************************

          Function
connect_lines(Begins at: 197, Ends at:327)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |     * |      WARNING |        13 |
ParamNBR:     |       6 |     * |      WARNING |         6 |
CalledNBR:    |      34 |       |           OK |        34 |
LOC:          |     131 |     * |      WARNING |       131 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Vedit_connect_lines(Begins at: 152, Ends at:195)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |    ** | BABY-MONSTER |         7 |
ParamNBR:     |       3 |    ** | BABY-MONSTER |         3 |
CalledNBR:    |       8 |    ** | BABY-MONSTER |         8 |
LOC:          |      44 |    ** | BABY-MONSTER |        44 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK


Vedit_split_lines(Begins at: 34, Ends at:133)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |    ** | BABY-MONSTER |        13 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      23 |    ** | BABY-MONSTER |        23 |
LOC:          |     100 |    ** | BABY-MONSTER |       100 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 2 potentially cloned functions:
  Vedit_split_lines

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/vedit/break.c clones of Vedit_connect_lines are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/vedit/break.c  Vedit_connect_lines

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/vector/vedit/break.c clones of Vedit_split_lines are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/vedit/break.c  Vedit_split_lines

*****************************************************************
          File :grass/branches/develbranch_6/vector/v.edit/main.c
*****************************************************************

          Function
main(Begins at: 23, Ends at:475)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      75 |   *** |      MONSTER |        75 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     184 |   *** |      MONSTER |       184 |
LOC:          |     453 |   *** |      MONSTER |       453 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold GRASS6 key metrics values at Thu Sep 04 15:32:06 EDT 2008 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
    SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 
    http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html