[GRASS-QA] GRASS QA: martinl |ellipse.c | 6 clones | 0 monsters |0
warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Thu Sep 4 15:29:34 EDT 2008
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/branches/develbranch_6/lib/proj/ellipse.c
*****************************************************************
Function
free_ellps_list(Begins at: 284, Ends at:297)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get_a_e2_rf(Begins at: 153, Ends at:194)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 42 | * | WARNING | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
GPJ_free_ellps(Begins at: 277, Ends at:282)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GPJ_get_ellipsoid_by_name(Begins at: 131, Ends at:151)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GPJ_get_ellipsoid_params(Begins at: 37, Ends at:49)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
GPJ__get_ellipsoid_params(Begins at: 51, Ends at:120)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 28 | ** | BABY-MONSTER | 28 |
LOC: | 70 | * | WARNING | 70 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
read_ellipsoid_table(Begins at: 196, Ends at:275)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 30 | ** | BABY-MONSTER | 30 |
LOC: | 80 | * | WARNING | 80 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 6 potentially cloned functions:
get_a_e2_rf GPJ_get_ellipsoid_by_name GPJ_get_ellipsoid_params GPJ__get_ellipsoid_params read_ellipsoid_table
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/ellipse.c clones of free_ellps_list are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/proj/ellipse.c free_ellps_list
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/ellipse.c clones of get_a_e2_rf are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/proj/ellipse.c get_a_e2_rf
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/ellipse.c clones of GPJ_get_ellipsoid_by_name are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/proj/ellipse.c GPJ_get_ellipsoid_by_name
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/ellipse.c clones of GPJ_get_ellipsoid_params are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/proj/ellipse.c GPJ_get_ellipsoid_params
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/ellipse.c clones of GPJ__get_ellipsoid_params are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/proj/ellipse.c GPJ__get_ellipsoid_params
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/proj/ellipse.c clones of read_ellipsoid_table are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/proj/ellipse.c read_ellipsoid_table
____________________________________________
Threshold GRASS6 key metrics values at Thu Sep 04 15:41:46 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list