[GRASS-QA] GRASS QA: glynn |bar.c main.c pie.c do_labels.c ...| 23
clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Fri Sep 5 10:56:29 EDT 2008
Hello glynn,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/display/d.histogram/bar.c
*****************************************************************
Function
bar(Begins at: 34, Ends at:436)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 49 | *** | MONSTER | 49 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 73 | *** | MONSTER | 73 |
LOC: | 403 | *** | MONSTER | 403 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
rem(Begins at: 439, Ends at:444)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/display/d.histogram/main.c
*****************************************************************
Function
main(Begins at: 59, Ends at:229)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | ** | BABY-MONSTER | 13 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 64 | *** | MONSTER | 64 |
LOC: | 171 | *** | MONSTER | 171 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/display/d.histogram/pie.c
*****************************************************************
Function
pie(Begins at: 42, Ends at:413)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 34 | *** | MONSTER | 34 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 63 | *** | MONSTER | 63 |
LOC: | 372 | *** | MONSTER | 372 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/display/d.histogram/pie.c clones of pie are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.histogram/pie.c pie
*****************************************************************
File :grass/trunk/display/d.labels/do_labels.c
*****************************************************************
Function
do_labels(Begins at: 70, Ends at:147)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 25 | *** | MONSTER | 25 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 47 | *** | MONSTER | 47 |
LOC: | 78 | * | WARNING | 78 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
initialize_options(Begins at: 43, Ends at:67)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
scan_ref(Begins at: 447, Ends at:468)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 22 | | OK | 22 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
show_it(Begins at: 149, Ends at:443)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 42 | *** | MONSTER | 42 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 63 | *** | MONSTER | 63 |
LOC: | 295 | *** | MONSTER | 295 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
xmatch(Begins at: 470, Ends at:487)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
ymatch(Begins at: 489, Ends at:510)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 22 | | OK | 22 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 16 potentially cloned functions:
do_labels initialize_options initialize_options initialize_options scan_ref scan_ref scan_ref show_it show_it xmatch xmatch xmatch ymatch ymatch ymatch
In /var/project-manager/grass/grassSVN/grass/trunk/display/d.labels/do_labels.c clones of do_labels are:
/var/project-manager/grass/grassSVN/grass/trunk/display/d.paint.labels/do_labels.c do_labels
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.paint.labels/do_labels.c do_labels
In /var/project-manager/grass/grassSVN/grass/trunk/display/d.labels/do_labels.c clones of initialize_options are:
/var/project-manager/grass/grassSVN/grass/trunk/display/d.paint.labels/do_labels.c initialize_options
/tmp/grassSVN/grass/trunk/display/d.labels/do_labels.c initialize_options
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.paint.labels/do_labels.c initialize_options
In /var/project-manager/grass/grassSVN/grass/trunk/display/d.labels/do_labels.c clones of scan_ref are:
/var/project-manager/grass/grassSVN/grass/trunk/display/d.paint.labels/do_labels.c scan_ref
/tmp/grassSVN/grass/trunk/display/d.labels/do_labels.c scan_ref
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.paint.labels/do_labels.c scan_ref
In /var/project-manager/grass/grassSVN/grass/trunk/display/d.labels/do_labels.c clones of show_it are:
/var/project-manager/grass/grassSVN/grass/trunk/display/d.paint.labels/do_labels.c show_it
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.paint.labels/do_labels.c show_it
In /var/project-manager/grass/grassSVN/grass/trunk/display/d.labels/do_labels.c clones of xmatch are:
/var/project-manager/grass/grassSVN/grass/trunk/display/d.paint.labels/do_labels.c xmatch
/tmp/grassSVN/grass/trunk/display/d.labels/do_labels.c xmatch
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.paint.labels/do_labels.c xmatch
In /var/project-manager/grass/grassSVN/grass/trunk/display/d.labels/do_labels.c clones of ymatch are:
/var/project-manager/grass/grassSVN/grass/trunk/display/d.paint.labels/do_labels.c ymatch
/tmp/grassSVN/grass/trunk/display/d.labels/do_labels.c ymatch
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.paint.labels/do_labels.c ymatch
*****************************************************************
File :grass/trunk/display/d.vect/attr.c
*****************************************************************
Function
attr(Begins at: 10, Ends at:213)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 35 | *** | MONSTER | 35 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 63 | *** | MONSTER | 63 |
LOC: | 204 | *** | MONSTER | 204 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/display/d.vect/label.c
*****************************************************************
Function
label(Begins at: 8, Ends at:154)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 29 | *** | MONSTER | 29 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 32 | ** | BABY-MONSTER | 32 |
LOC: | 147 | *** | MONSTER | 147 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/display/d.vect/local_proto.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/display/d.vect/plot.h
*****************************************************************
Class
rgb_color(Begins at: 3, Ends at:6)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/display/d.vect/plot1.c
*****************************************************************
Function
plot1(Begins at: 80, Ends at:479)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 60 | *** | MONSTER | 60 |
ParamNBR: | 18 | *** | MONSTER | 18 |
CalledNBR: | 95 | *** | MONSTER | 95 |
LOC: | 400 | *** | MONSTER | 400 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
plot_polygon(Begins at: 62, Ends at:75)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
plot_polyline(Begins at: 44, Ends at:57)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 6 potentially cloned functions:
plot_polyline plot_polyline plot_polyline plot_polygon plot_polygon
In /var/project-manager/grass/grassSVN/grass/trunk/display/d.vect/plot1.c clones of plot_polygon are:
/var/project-manager/grass/grassSVN/grass/trunk/display/d.thematic.area/plot1.c plot_polygon
/var/project-manager/grass/grassSVN/grass/trunk/display/d.thematic.area/plot1.c plot_polyline
/var/project-manager/grass/grassSVN/grass/trunk/display/d.vect/plot1.c plot_polyline
In /var/project-manager/grass/grassSVN/grass/trunk/display/d.vect/plot1.c clones of plot_polyline are:
/var/project-manager/grass/grassSVN/grass/trunk/display/d.thematic.area/plot1.c plot_polyline
/var/project-manager/grass/grassSVN/grass/trunk/display/d.thematic.area/plot1.c plot_polygon
/var/project-manager/grass/grassSVN/grass/trunk/display/d.vect/plot1.c plot_polygon
*****************************************************************
File :grass/trunk/display/d.vect/topo.c
*****************************************************************
Function
topo(Begins at: 8, Ends at:186)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 25 | *** | MONSTER | 25 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 51 | *** | MONSTER | 51 |
LOC: | 179 | *** | MONSTER | 179 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/display/d.vect/utils.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/display/d.vect/zcoor.c
*****************************************************************
Function
zcoor(Begins at: 9, Ends at:98)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 27 | ** | BABY-MONSTER | 27 |
LOC: | 90 | * | WARNING | 85 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold GRASS6 key metrics values at Fri Sep 05 11:01:50 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list