[GRASS-QA] GRASS QA: glynn |gisdefs.h sample.c main.c | 5 clones | 0
monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Fri Sep 5 11:15:56 EDT 2008
Hello glynn,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/include/gisdefs.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/gis/sample.c
*****************************************************************
Function
G_get_raster_sample(Begins at: 62, Ends at:88)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 27 | | OK | 27 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
raster_row_error(Begins at: 463, Ends at:471)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
raster_sample_bilinear(Begins at: 126, Ends at:249)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 20 | ** | BABY-MONSTER | 20 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 47 | *** | MONSTER | 47 |
LOC: | 124 | ** | BABY-MONSTER | 124 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
raster_sample_cubic(Begins at: 252, Ends at:445)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 45 | *** | MONSTER | 45 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 82 | *** | MONSTER | 82 |
LOC: | 194 | *** | MONSTER | 194 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
raster_sample_nearest(Begins at: 91, Ends at:123)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metrics are OK
scancatlabel(Begins at: 448, Ends at:460)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 5 potentially cloned functions:
raster_sample_bilinear raster_sample_cubic raster_sample_nearest scancatlabel
In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/sample.c clones of G_get_raster_sample are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/sample.c G_get_raster_sample
In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/sample.c clones of raster_sample_bilinear are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/sample.c raster_sample_bilinear
In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/sample.c clones of raster_sample_cubic are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/sample.c raster_sample_cubic
In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/sample.c clones of raster_sample_nearest are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/sample.c raster_sample_nearest
In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/sample.c clones of scancatlabel are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/sample.c scancatlabel
*****************************************************************
File :grass/trunk/vector/v.sample/main.c
*****************************************************************
Function
main(Begins at: 51, Ends at:294)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 24 | *** | MONSTER | 24 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 107 | *** | MONSTER | 107 |
LOC: | 244 | *** | MONSTER | 244 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold GRASS6 key metrics values at Fri Sep 05 11:21:18 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list