[GRASS-QA] GRASS QA: martinl |main.c | 2 clones | 0 monsters |0 warnings

[soccerlab.info at gmail.com]

Hello martinl,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/vector/v.extrude/main.c
*****************************************************************

          Function
extrude(Begins at: 380, Ends at:514)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      19 |    ** | BABY-MONSTER |        19 |
ParamNBR:     |      11 |   *** |      MONSTER |        11 |
CalledNBR:    |      23 |    ** | BABY-MONSTER |        23 |
LOC:          |     135 |    ** | BABY-MONSTER |       135 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


main(Begins at: 34, Ends at:356)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      33 |   *** |      MONSTER |        33 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     127 |   *** |      MONSTER |       127 |
LOC:          |     323 |   *** |      MONSTER |       323 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 2 potentially cloned functions:
  main

In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.extrude/main.c clones of extrude are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.extrude/main.c  extrude

In /var/project-manager/grass/grassSVN/grass/trunk/vector/v.extrude/main.c clones of main are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.extrude/main.c  main

____________________________________________


Threshold GRASS6 key metrics values at Fri Sep 05 11:43:16 EDT 2008 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
    SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 
    http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html