[GRASS-QA] GRASS QA: glynn |main.c main.c dhist.h get_stats.c ...| 29 clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Fri Sep 5 12:51:48 EDT 2008


Hello glynn,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/display/d.colortable/main.c
*****************************************************************

          Function
main(Begins at: 30, Ends at:270)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      25 |   *** |      MONSTER |        25 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      70 |   *** |      MONSTER |        70 |
LOC:          |     241 |   *** |      MONSTER |       241 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/display/d.his/main.c
*****************************************************************

          Function
main(Begins at: 31, Ends at:271)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      27 |   *** |      MONSTER |        27 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      84 |   *** |      MONSTER |        84 |
LOC:          |     241 |   *** |      MONSTER |       241 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/display/d.histogram/dhist.h
*****************************************************************

          Class
stat_list(Begins at: 8, Ends at:19)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------+



          Class
stat_node(Begins at: 1, Ends at:6)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------+



          Class
units(Begins at: 22, Ends at:27)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------+



Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/display/d.histogram/get_stats.c
*****************************************************************

          Function
get_stats(Begins at: 37, Ends at:163)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      22 |   *** |      MONSTER |        22 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      28 |    ** | BABY-MONSTER |        28 |
LOC:          |     127 |    ** | BABY-MONSTER |       127 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


mk_command(Begins at: 10, Ends at:35)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      26 |       |           OK |        26 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 2 potentially cloned functions:
  mk_command

In /var/project-manager/grass/grassSVN/grass/trunk/display/d.histogram/get_stats.c clones of get_stats are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.histogram/get_stats.c  get_stats

In /var/project-manager/grass/grassSVN/grass/trunk/display/d.histogram/get_stats.c clones of mk_command are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.histogram/get_stats.c  mk_command

*****************************************************************
          File :grass/trunk/display/d.histogram/main.c
*****************************************************************

          Function
main(Begins at: 59, Ends at:229)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |    ** | BABY-MONSTER |        13 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      64 |   *** |      MONSTER |        64 |
LOC:          |     171 |   *** |      MONSTER |       171 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/display/d.legend/main.c
*****************************************************************

          Function
main(Begins at: 38, Ends at:885)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |     130 |   *** |      MONSTER |       130 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     211 |   *** |      MONSTER |       211 |
LOC:          |     848 |   *** |      MONSTER |       848 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/display/d.path/main.c
*****************************************************************

          Function
main(Begins at: 31, Ends at:205)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |    ** | BABY-MONSTER |        14 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      79 |   *** |      MONSTER |        79 |
LOC:          |     175 |   *** |      MONSTER |       175 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/display/d.rast/colors.c
*****************************************************************

          Function
color_list(Begins at: 4, Ends at:17)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      14 |       |           OK |        14 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


get_rgb(Begins at: 19, Ends at:30)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      12 |       |           OK |        12 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 2 potentially cloned functions:
  get_rgb

In /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/colors.c clones of color_list are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/colors.c  color_list

In /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/colors.c clones of get_rgb are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/colors.c  get_rgb

*****************************************************************
          File :grass/trunk/display/d.rast/display.c
*****************************************************************

          Function
cell_draw(Begins at: 46, Ends at:92)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |      20 |     * |      WARNING |        20 |
LOC:          |      47 |     * |      WARNING |        47 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK


display(Begins at: 12, Ends at:44)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      33 |       |           OK |        33 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK


mask_raster_array(Begins at: 94, Ends at:103)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 2 potentially cloned functions:
  mask_raster_array

In /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/display.c clones of cell_draw are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/display.c  cell_draw

In /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/display.c clones of mask_raster_array are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/display.c  mask_raster_array

*****************************************************************
          File :grass/trunk/display/d.rast/local_proto.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/trunk/display/d.rast/main.c
*****************************************************************

          Function
main(Begins at: 35, Ends at:137)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      36 |    ** | BABY-MONSTER |        36 |
LOC:          |     103 |    ** | BABY-MONSTER |       103 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK


parse_catlist(Begins at: 139, Ends at:169)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      31 |       |           OK |        31 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


parse_d_mask_rule(Begins at: 234, Ends at:263)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      11 |     * |      WARNING |        11 |
LOC:          |      30 |       |           OK |        30 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


parse_mask_rule(Begins at: 203, Ends at:232)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      11 |     * |      WARNING |        11 |
LOC:          |      30 |       |           OK |        30 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


parse_vallist(Begins at: 171, Ends at:201)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      31 |       |           OK |        31 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 18 potentially cloned functions:
  parse_vallist  parse_catlist  parse_vallist  parse_vallist  parse_vallist  parse_mask_rule  parse_mask_rule  parse_d_mask_rule  parse_d_mask_rule  parse_mask_rule  parse_d_mask_rule  parse_catlist  parse_vallist  parse_catlist  parse_vallist  parse_vallist  parse_vallist

In /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/main.c clones of parse_catlist are:
          /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/main.c  parse_vallist
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.null/null.c  parse_vallist
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/main.c  parse_catlist
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/main.c  parse_vallist
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.null/null.c  parse_vallist
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.null/main.c  parse_vallist

In /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/main.c clones of parse_d_mask_rule are:
          /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/main.c  parse_mask_rule
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/main.c  parse_mask_rule
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/main.c  parse_d_mask_rule

In /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/main.c clones of parse_mask_rule are:
          /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/main.c  parse_d_mask_rule
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/main.c  parse_mask_rule
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/main.c  parse_d_mask_rule

In /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/main.c clones of parse_vallist are:
          /var/project-manager/grass/grassSVN/grass/trunk/display/d.rast/main.c  parse_catlist
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.null/null.c  parse_vallist
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/main.c  parse_catlist
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.rast/main.c  parse_vallist
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.null/null.c  parse_vallist
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.null/main.c  parse_vallist

*****************************************************************
          File :grass/trunk/display/d.rast.arrow/main.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/trunk/display/d.rast.num/main.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/trunk/display/d.rgb/main.c
*****************************************************************

          Class
band(Begins at: 28, Ends at:35)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------+



          Function
main(Begins at: 39, Ends at:143)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |    ** | BABY-MONSTER |        14 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      41 |   *** |      MONSTER |        41 |
LOC:          |     105 |    ** | BABY-MONSTER |       105 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/display/d.thematic.area/main.c
*****************************************************************

          Function
main(Begins at: 33, Ends at:536)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      51 |   *** |      MONSTER |        51 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     164 |   *** |      MONSTER |       164 |
LOC:          |     504 |   *** |      MONSTER |       504 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/display/d.title/fancy.c
*****************************************************************

          Function
fancy(Begins at: 4, Ends at:19)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      11 |     * |      WARNING |        11 |
LOC:          |      16 |       |           OK |        16 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 1 potentially cloned functions:


In /var/project-manager/grass/grassSVN/grass/trunk/display/d.title/fancy.c clones of fancy are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.title/fancy.c  fancy

*****************************************************************
          File :grass/trunk/display/d.title/local_proto.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/trunk/display/d.title/main.c
*****************************************************************

          Function
main(Begins at: 34, Ends at:146)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      48 |   *** |      MONSTER |        48 |
LOC:          |     113 |    ** | BABY-MONSTER |       113 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 1 potentially cloned functions:


In /var/project-manager/grass/grassSVN/grass/trunk/display/d.title/main.c clones of main are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.title/main.c  main

*****************************************************************
          File :grass/trunk/display/d.title/normal.c
*****************************************************************

          Function
normal(Begins at: 4, Ends at:25)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      10 |     * |      WARNING |        10 |
LOC:          |      22 |       |           OK |        22 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 1 potentially cloned functions:


In /var/project-manager/grass/grassSVN/grass/trunk/display/d.title/normal.c clones of normal are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.title/normal.c  normal

*****************************************************************
          File :grass/trunk/display/d.title/options.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/trunk/display/d.vect/main.c
*****************************************************************

          Function
icon_files(Begins at: 32, Ends at:76)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |     * |      WARNING |         8 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      14 |     * |      WARNING |        14 |
LOC:          |      45 |     * |      WARNING |        45 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


main(Begins at: 78, Ends at:720)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      80 |   *** |      MONSTER |        80 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     202 |   *** |      MONSTER |       202 |
LOC:          |     643 |   *** |      MONSTER |       643 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/display/d.vect.chart/main.c
*****************************************************************

          Function
main(Begins at: 30, Ends at:284)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      21 |   *** |      MONSTER |        21 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      65 |   *** |      MONSTER |        65 |
LOC:          |     255 |   *** |      MONSTER |       255 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/display/d.zoom/main.c
*****************************************************************

          Function
main(Begins at: 38, Ends at:280)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      33 |   *** |      MONSTER |        33 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      58 |   *** |      MONSTER |        58 |
LOC:          |     243 |   *** |      MONSTER |       243 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/lib/gis/nme_in_mps.c
*****************************************************************

          Function
G_fully_qualified_name(Begins at: 118, Ends at:128)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      11 |       |           OK |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


G__name_in_mapset(Begins at: 33, Ends at:40)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


G__name_is_fully_qualified(Begins at: 57, Ends at:85)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      29 |       |           OK |        29 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 2 potentially cloned functions:
  G__name_is_fully_qualified

In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/nme_in_mps.c clones of G_fully_qualified_name are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/nme_in_mps.c  G_fully_qualified_name

In /var/project-manager/grass/grassSVN/grass/trunk/lib/gis/nme_in_mps.c clones of G__name_is_fully_qualified are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/gis/nme_in_mps.c  G__name_is_fully_qualified

____________________________________________


Threshold GRASS6 key metrics values at Fri Sep 05 12:57:11 EDT 2008 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
    SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 
    http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html 



More information about the grass-qa mailing list