[GRASS-QA] GRASS QA: glynn |main.c | 9 clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Fri Sep 5 13:23:04 EDT 2008
Hello glynn,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/raster/r.colors/main.c
*****************************************************************
Function
find_rule(Begins at: 124, Ends at:133)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
list_rules(Begins at: 116, Ends at:122)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 135, Ends at:366)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 36 | *** | MONSTER | 36 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 97 | *** | MONSTER | 97 |
LOC: | 232 | *** | MONSTER | 232 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metrics are OK
rules_descriptions(Begins at: 76, Ends at:114)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 11 | | OK | 11 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
rules_list(Begins at: 50, Ends at:74)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
scan_rules(Begins at: 35, Ends at:48)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 8 | * | WARNING | 8 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 9 potentially cloned functions:
which_item is_toy_font GS_setall_drawmode GS_setall_drawmode which_item GS_setall_drawmode rules_list scan_rules
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.colors/main.c clones of find_rule are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.colors/main.c find_rule
/var/project-manager/grass/grassSVN/grass/trunk/display/d.save/main.c which_item
/var/project-manager/grass/grassSVN/grass/trunk/lib/cairodriver/Text.c is_toy_font
/var/project-manager/grass/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_setall_drawmode
/tmp/grassSVN/grass/trunk/lib/ogsf/GS2.c GS_setall_drawmode
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/display/d.save/main.c which_item
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/ogsf/GS2.c GS_setall_drawmode
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.colors/main.c clones of rules_list are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.colors/main.c rules_list
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.colors/main.c clones of scan_rules are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/raster/r.colors/main.c scan_rules
____________________________________________
Threshold GRASS6 key metrics values at Fri Sep 05 13:28:27 EDT 2008 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html
More information about the grass-qa
mailing list