[GRASS-QA] GRASS QA: martinl |cats.cpp line.cpp vertex.cpp | no clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Fri Sep 5 14:46:12 EDT 2008


Hello martinl,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/gui/wxpython/vdigit/cats.cpp
*****************************************************************

          Class
Digit(Begins at: -9999, Ends at:-9999)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |     37 |    113 |      0 |     21 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |     37 |    113 |      0 |     21 |
+------------+--------+--------+--------+--------+--------+--------+

          Method
CopyCats(Begins at: 293, Ends at:298)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |       6 |       |           OK |         6 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

GetCategory(Begins at: 90, Ends at:98)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |       9 |       |           OK |         9 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

GetLayers(Begins at: 134, Ends at:144)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      11 |       |           OK |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

GetLineCats(Begins at: 153, Ends at:202)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      50 |     * |      WARNING |        50 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK

InitCats(Begins at: 26, Ends at:80)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |      13 |     * |      WARNING |        13 |
LOC:          |      55 |     * |      WARNING |        55 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK

SetCategory(Begins at: 109, Ends at:125)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      17 |       |           OK |        17 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

SetLineCats(Begins at: 215, Ends at:282)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      10 |     * |      WARNING |        10 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      19 |     * |      WARNING |        19 |
LOC:          |      68 |     * |      WARNING |        68 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK



Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/gui/wxpython/vdigit/line.cpp
*****************************************************************

          Class
Digit(Begins at: -9999, Ends at:-9999)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |    112 |    402 |      0 |     91 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |    112 |    402 |      0 |     91 |
+------------+--------+--------+--------+--------+--------+--------+

          Method
AddLine(Begins at: 38, Ends at:182)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      20 |     * |      WARNING |        20 |
ParamNBR:     |       7 |       |           OK |         7 |
CalledNBR:    |      41 |       |           OK |        41 |
LOC:          |     145 |       |           OK |       145 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK

BreakLines(Begins at: 614, Ends at:651)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      38 |       |           OK |        38 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

ConnectLines(Begins at: 681, Ends at:712)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |    ** | BABY-MONSTER |         5 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       8 |    ** | BABY-MONSTER |         8 |
LOC:          |      32 |    ** | BABY-MONSTER |        32 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK

CopyLines(Begins at: 752, Ends at:807)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |       |           OK |         9 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      16 |       |           OK |        16 |
LOC:          |      56 |       |           OK |        56 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

DeleteLines(Begins at: 338, Ends at:461)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      17 |     * |      WARNING |        17 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      27 |       |           OK |        27 |
LOC:          |     124 |       |           OK |       124 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK

FlipLines(Begins at: 532, Ends at:560)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       0 |       |           OK |         0 |
CalledNBR:    |       5 |       |           OK |         5 |
LOC:          |      29 |       |           OK |        29 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

MergeLines(Begins at: 568, Ends at:604)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       0 |     * |      WARNING |         0 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      37 |       |           OK |        37 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK

MoveLines(Begins at: 475, Ends at:524)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       6 |       |           OK |         6 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      50 |       |           OK |        50 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK

OpenBackgroundVectorMap(Begins at: 819, Ends at:857)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |    ** | BABY-MONSTER |         6 |
ParamNBR:     |       1 |    ** | BABY-MONSTER |         1 |
CalledNBR:    |      14 |   *** |      MONSTER |        14 |
LOC:          |      39 |   *** |      MONSTER |        39 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK

RewriteLine(Begins at: 196, Ends at:283)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |     * |      WARNING |        13 |
ParamNBR:     |       5 |       |           OK |         5 |
CalledNBR:    |      20 |     * |      WARNING |        20 |
LOC:          |      88 |     * |      WARNING |        88 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK

SnapLines(Begins at: 663, Ends at:673)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |     * |      WARNING |         2 |
ParamNBR:     |       1 |    ** | BABY-MONSTER |         1 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      11 |     * |      WARNING |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK

SplitLine(Begins at: 296, Ends at:328)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |     * |      WARNING |         4 |
ParamNBR:     |       4 |       |           OK |         4 |
CalledNBR:    |       9 |     * |      WARNING |         9 |
LOC:          |      33 |       |           OK |        33 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK

TypeConvLines(Begins at: 869, Ends at:901)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |    ** | BABY-MONSTER |         5 |
ParamNBR:     |       0 |     * |      WARNING |         0 |
CalledNBR:    |       7 |     * |      WARNING |         7 |
LOC:          |      33 |     * |      WARNING |        33 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK

ZBulkLabeling(Begins at: 728, Ends at:741)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      14 |       |           OK |        14 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
metrics are OK



Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/gui/wxpython/vdigit/vertex.cpp
*****************************************************************

          Class
Digit(Begins at: -9999, Ends at:-9999)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |     12 |     58 |      0 |      1 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |      1 |      0 |     12 |     58 |      0 |      1 |
+------------+--------+--------+--------+--------+--------+--------+

          Method
ModifyLineVertex(Begins at: 108, Ends at:146)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      11 |     * |      WARNING |        11 |
LOC:          |      39 |       |           OK |        39 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK

MoveVertex(Begins at: 37, Ends at:93)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |      10 |   *** |      MONSTER |        10 |
CalledNBR:    |      13 |     * |      WARNING |        13 |
LOC:          |      57 |     * |      WARNING |        57 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
metrics are OK



Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold GRASS6 key metrics values at Fri Sep 05 14:51:36 EDT 2008 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
    SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 
    http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html 



More information about the grass-qa mailing list