[GRASS-QA] GRASS QA: hamish |test.c | 24 clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Wed Sep 10 20:41:35 EDT 2008


Hello hamish,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/branches/develbranch_6/swig/python/NumPtr/src/test.c
*****************************************************************

          Function
test1(Begins at: 1, Ends at:8)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


test2(Begins at: 10, Ends at:19)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


test3(Begins at: 21, Ends at:32)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      12 |       |           OK |        12 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


testd1(Begins at: 34, Ends at:41)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


testd2(Begins at: 43, Ends at:52)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


testd3(Begins at: 54, Ends at:65)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      12 |       |           OK |        12 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


testf1(Begins at: 67, Ends at:74)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


testf2(Begins at: 76, Ends at:85)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


testf3(Begins at: 87, Ends at:98)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      12 |       |           OK |        12 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


testi1(Begins at: 100, Ends at:107)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


testi2(Begins at: 109, Ends at:118)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


testi3(Begins at: 120, Ends at:131)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      12 |       |           OK |        12 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 24 potentially cloned functions:
  testf2  testi2  testd3  testf3  testi3  test2  testf2  testi2  test3  testf3  testi3  test2  testd2  testi2  test3  testd3  testi3  test2  testd2  testf2  test3  testd3  testf3

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c clones of test2 are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testd2
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testf2
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testi2

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c clones of test3 are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testd3
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testf3
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testi3

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c clones of testd2 are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  test2
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testf2
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testi2

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c clones of testd3 are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  test3
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testf3
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testi3

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c clones of testf2 are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  test2
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testd2
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testi2

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c clones of testf3 are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  test3
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testd3
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testi3

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c clones of testi2 are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  test2
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testd2
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testf2

In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c clones of testi3 are:
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  test3
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testd3
          /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/swig/python/NumPtr/src/test.c  testf3

____________________________________________


Threshold GRASS6 key metrics values at Wed Sep 10 20:48:06 EDT 2008 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Please visite our web site on your project at :http://web.soccerlab.polymtl.ca/project-manager/index.html
Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
    SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 
    http://web.soccerlab.polymtl.ca/grass-evolution/grass-browsers/grass-index-en.html 



More information about the grass-qa mailing list