[GRASS-QA] GRASS QA: martinl |c_assign.c c_begin.c c_clear.c
c_distinct.c ...| no clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Wed Aug 5 13:44:44 EDT 2009
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/lib/cluster/c_assign.c
*****************************************************************
Function
I_cluster_assign(Begins at: 4, Ends at:41)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 38 | | OK | 38 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_begin.c
*****************************************************************
Function
I_cluster_begin(Begins at: 16, Ends at:77)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 14 | ** | BABY-MONSTER | 14 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 62 | * | WARNING | 62 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_clear.c
*****************************************************************
Function
I_cluster_clear(Begins at: 2, Ends at:19)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_distinct.c
*****************************************************************
Function
I_cluster_distinct(Begins at: 3, Ends at:34)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 32 | | OK | 32 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_exec.c
*****************************************************************
Function
I_cluster_exec(Begins at: 23, Ends at:123)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 20 | ** | BABY-MONSTER | 20 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 101 | ** | BABY-MONSTER | 101 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_execmem.c
*****************************************************************
Function
I_cluster_exec_allocate(Begins at: 3, Ends at:25)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
I_cluster_exec_free(Begins at: 27, Ends at:47)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_means.c
*****************************************************************
Function
I_cluster_means(Begins at: 4, Ends at:28)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_merge.c
*****************************************************************
Function
I_cluster_merge(Begins at: 3, Ends at:22)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 20 | | OK | 20 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_nclasses.c
*****************************************************************
Function
I_cluster_nclasses(Begins at: 3, Ends at:12)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_point.c
*****************************************************************
Function
I_cluster_begin_point_set(Begins at: 54, Ends at:57)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
I_cluster_end_point_set(Begins at: 72, Ends at:88)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 17 | | OK | 17 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
I_cluster_point(Begins at: 24, Ends at:52)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 29 | | OK | 29 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
I_cluster_point_part(Begins at: 59, Ends at:70)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
all_zero(Begins at: 90, Ends at:98)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
extend(Begins at: 100, Ends at:114)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_reassign.c
*****************************************************************
Function
I_cluster_reassign(Begins at: 4, Ends at:74)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | ** | BABY-MONSTER | 15 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 71 | * | WARNING | 71 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_reclass.c
*****************************************************************
Function
I_cluster_reclass(Begins at: 3, Ends at:35)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_sep.c
*****************************************************************
Function
I_cluster_separation(Begins at: 6, Ends at:60)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 55 | * | WARNING | 55 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_sig.c
*****************************************************************
Function
I_cluster_signatures(Begins at: 2, Ends at:58)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | ** | BABY-MONSTER | 13 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 57 | * | WARNING | 57 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/lib/cluster/c_sum2.c
*****************************************************************
Function
I_cluster_sum2(Begins at: 4, Ends at:27)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Wed Aug 05 13:33:00 EDT 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list