[GRASS-QA] GRASS QA: huhabla |gisdefs.h gmath.h ATLAS_wrapper_blas_level_1.c blas_level_1.c ...| no clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Thu Aug 27 17:07:44 EDT 2009


Hello huhabla,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/branches/develbranch_6/include/gisdefs.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/include/gmath.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/ATLAS_wrapper_blas_level_1.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/blas_level_1.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/blas_level_2.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/blas_level_3.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/ccmath_grass_wrapper.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/del2g.c
*****************************************************************

          Function
del2g(Begins at: 46, Ends at:73)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      17 |     * |      WARNING |        17 |
LOC:          |      28 |       |           OK |        28 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/eigen.c
*****************************************************************

          Function
egcmp(Begins at: 135, Ends at:146)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      12 |       |           OK |        12 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


egvorder2(Begins at: 70, Ends at:104)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      35 |       |           OK |        35 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


eigen(Begins at: 26, Ends at:54)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |      29 |       |           OK |        29 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


transpose2(Begins at: 119, Ends at:132)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      14 |       |           OK |        14 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/eigen_tools.c
*****************************************************************

          Function
G_tqli(Begins at: 9, Ends at:74)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      10 |     * |      WARNING |        10 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      66 |     * |      WARNING |        66 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


G_tred2(Begins at: 77, Ends at:156)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      17 |    ** | BABY-MONSTER |        17 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      80 |     * |      WARNING |        80 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/jacobi.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/mult.c
*****************************************************************

          Function
mult(Begins at: 22, Ends at:44)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      23 |       |           OK |        23 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/solvers_classic_iter.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/solvers_direct.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/solvers_krylov.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/sparse_matrix.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/svd.c
*****************************************************************

          Function
G_svbksb(Begins at: 236, Ends at:261)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      26 |       |           OK |        26 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


G_svdcmp(Begins at: 15, Ends at:230)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      57 |   *** |      MONSTER |        57 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      19 |     * |      WARNING |        19 |
LOC:          |     216 |   *** |      MONSTER |       216 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


G_svelim(Begins at: 265, Ends at:280)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |      16 |       |           OK |        16 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/bench_blas2.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/bench_blas3.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/bench_solver_direct.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/bench_solver_krylov.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/test_blas1.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/test_blas2.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/test_blas3.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/test_ccmath_wrapper.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/test_gmath_lib.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/test_main.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/test_solvers.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/test_tools.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :grass/branches/develbranch_6/lib/gmath/test/test_tools_les.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
____________________________________________


Threshold grass key metrics values at Thu Aug 27 16:45:53 EDT 2009 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list