[GRASS-QA] GRASS QA: neteler |form.c form.c | 6 clones | 0 monsters
|0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Wed Feb 4 11:28:56 EST 2009
Hello neteler,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/branches/develbranch_6/lib/form/form.c
*****************************************************************
Function
Tcl_AppInit(Begins at: 267, Ends at:299)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 33 | | OK | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
main(Begins at: 301, Ends at:308)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
reset_values(Begins at: 30, Ends at:40)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
set_value(Begins at: 42, Ends at:71)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 13 | * | WARNING | 13 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
submit(Begins at: 74, Ends at:262)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 20 | ** | BABY-MONSTER | 20 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 92 | *** | MONSTER | 92 |
LOC: | 189 | *** | MONSTER | 189 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 3 potentially cloned functions:
set_value submit
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/form/form.c clones of reset_values are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.digit/form.c reset_values
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/form/form.c clones of set_value are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.digit/form.c set_value
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/form/form.c clones of submit are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.digit/form.c submit
*****************************************************************
File :grass/branches/develbranch_6/vector/v.digit/form.c
*****************************************************************
Function
reset_values(Begins at: 30, Ends at:40)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
set_value(Begins at: 42, Ends at:71)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 13 | * | WARNING | 13 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
submit(Begins at: 74, Ends at:262)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 20 | ** | BABY-MONSTER | 20 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 92 | *** | MONSTER | 92 |
LOC: | 189 | *** | MONSTER | 189 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 3 potentially cloned functions:
set_value submit
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.digit/form.c clones of reset_values are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/form/form.c reset_values
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.digit/form.c clones of set_value are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/form/form.c set_value
In /var/project-manager/grass/grassSVN/grass/branches/develbranch_6/vector/v.digit/form.c clones of submit are:
/var/project-manager/grass/grassSVN/grass/branches/develbranch_6/lib/form/form.c submit
____________________________________________
Threshold grass key metrics values at Wed Feb 04 11:52:43 EST 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list