[GRASS-QA] GRASS QA: martinl |driver.cpp driver.h | 4 clones | 0
monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Tue Feb 24 14:32:38 EST 2009
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/gui/wxpython/vdigit/driver.cpp
*****************************************************************
Class
DisplayDriver(Begins at: -9999, Ends at:-9999)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 149 | 483 | 0 | 528 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 149 | 483 | 0 | 528 |
+------------+--------+--------+--------+--------+--------+--------+
Method
Cell2Pixel(Begins at: 697, Ends at:720)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 24 | | OK | 24 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
CloseMap(Begins at: 601, Ends at:619)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
DisplayDriver(Begins at: 32, Ends at:52)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
DistanceInPixels(Begins at: 729, Ends at:736)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
DrawArea(Begins at: 243, Ends at:260)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | * | WARNING | 1 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 18 | | OK | 18 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
DrawArrow(Begins at: 1509, Ends at:1527)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 6 | * | WARNING | 6 |
CalledNBR: | 6 | *** | MONSTER | 6 |
LOC: | 19 | *** | MONSTER | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
DrawCross(Begins at: 787, Ends at:795)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
DrawDirectionArrow(Begins at: 1428, Ends at:1497)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | | OK | 9 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 70 | | OK | 70 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
DrawLine(Begins at: 270, Ends at:432)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 25 | | OK | 25 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 45 | | OK | 45 |
LOC: | 163 | | OK | 163 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
DrawLineNodes(Begins at: 508, Ends at:590)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | | OK | 11 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 17 | | OK | 17 |
LOC: | 83 | | OK | 83 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
DrawLineVerteces(Begins at: 444, Ends at:498)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | | OK | 9 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 19 | | OK | 19 |
LOC: | 55 | | OK | 55 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
DrawMap(Begins at: 95, Ends at:233)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | | OK | 17 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 39 | | OK | 39 |
LOC: | 139 | | OK | 139 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
DrawSelected(Begins at: 1416, Ends at:1421)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | * | WARNING | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GetDuplicates(Begins at: 1099, Ends at:1141)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | | OK | 7 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 17 | | OK | 17 |
LOC: | 43 | * | WARNING | 43 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
GetMapBoundingBox(Begins at: 1374, Ends at:1394)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GetSelected(Begins at: 1072, Ends at:1092)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
GetSelectedVertex(Begins at: 1221, Ends at:1294)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | | OK | 8 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 11 | | OK | 11 |
LOC: | 74 | | OK | 74 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
IsDuplicated(Begins at: 1151, Ends at:1157)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | *** | MONSTER | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
IsSelected(Begins at: 1056, Ends at:1062)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
ListToVector(Begins at: 1331, Ends at:1343)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
OpenMap(Begins at: 630, Ends at:657)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 3 | | OK | 3 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
PrintIds(Begins at: 881, Ends at:922)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 42 | | OK | 42 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
ReloadMap(Begins at: 670, Ends at:684)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
ResetTopology(Begins at: 1301, Ends at:1322)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | ** | BABY-MONSTER | 0 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 22 | | OK | 22 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
SelectLineByPoint(Begins at: 1011, Ends at:1046)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | * | WARNING | 4 |
ParamNBR: | 6 | | OK | 6 |
CalledNBR: | 9 | * | WARNING | 9 |
LOC: | 36 | * | WARNING | 36 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
SelectLinesByBox(Begins at: 939, Ends at:996)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 8 | * | WARNING | 8 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 58 | * | WARNING | 58 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
SetDevice(Begins at: 82, Ends at:87)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | * | WARNING | 1 |
ParamNBR: | 1 | * | WARNING | 1 |
CalledNBR: | 0 | * | WARNING | 0 |
LOC: | 6 | * | WARNING | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
SetRegion(Begins at: 747, Ends at:774)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | ** | BABY-MONSTER | 1 |
ParamNBR: | 10 | | OK | 10 |
CalledNBR: | 0 | *** | MONSTER | 0 |
LOC: | 28 | ** | BABY-MONSTER | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
SetSelected(Begins at: 1166, Ends at:1176)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | * | WARNING | 2 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | * | WARNING | 1 |
LOC: | 11 | * | WARNING | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
UnSelect(Begins at: 1185, Ends at:1206)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | * | WARNING | 5 |
ParamNBR: | 1 | * | WARNING | 1 |
CalledNBR: | 6 | * | WARNING | 6 |
LOC: | 22 | * | WARNING | 22 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
UpdateSettings(Begins at: 806, Ends at:870)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 30 | ** | BABY-MONSTER | 30 |
CalledNBR: | 19 | | OK | 19 |
LOC: | 65 | | OK | 65 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
VectorToList(Begins at: 1354, Ends at:1367)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | * | WARNING | 3 |
ParamNBR: | 2 | ** | BABY-MONSTER | 2 |
CalledNBR: | 4 | * | WARNING | 4 |
LOC: | 14 | * | WARNING | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
~DisplayDriver(Begins at: 63, Ends at:73)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 0 | *** | MONSTER | 0 |
CalledNBR: | 5 | * | WARNING | 5 |
LOC: | 11 | * | WARNING | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Function
print_error(Begins at: 1404, Ends at:1409)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 4 potentially cloned functions:
/var/project-manager/grass/grassSVN/grass/trunk/include/iostream/mem_stream.h /var/project-manager/grass/grassSVN/grass/trunk/raster/r.terraflow/IOStream/include/mem_stream.h /var/project-manager/grass/grassSVN/grass/trunk/raster/r.terraflow/IOStream/include/mem_stream.h
In /var/project-manager/grass/grassSVN/grass/trunk/gui/wxpython/vdigit/driver.cpp clones of 1166 are:
1176 /var/project-manager/grass/grassSVN/grass/trunk/include/iostream/mem_stream.h
1176 /var/project-manager/grass/grassSVN/grass/trunk/include/iostream/mem_stream.h
1176 /var/project-manager/grass/grassSVN/grass/trunk/raster/r.terraflow/IOStream/include/mem_stream.h
1176 /var/project-manager/grass/grassSVN/grass/trunk/raster/r.terraflow/IOStream/include/mem_stream.h
*****************************************************************
File :grass/trunk/gui/wxpython/vdigit/driver.h
*****************************************************************
Class
DisplayDriver(Begins at: 32, Ends at:217)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 33 | 0 | 528 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 33 | 0 | 528 |
+------------+--------+--------+--------+--------+--------+--------+
Class
_region(Begins at: 69, Ends at:83)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
_settings(Begins at: 90, Ends at:115)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
_topology(Begins at: 117, Ends at:135)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
symbol(Begins at: 85, Ends at:88)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Tue Feb 24 14:36:17 EST 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list