[GRASS-QA] GRASS QA: mmetz |net.c | 1 clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Fri Feb 27 09:39:04 EST 2009
Hello mmetz,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/lib/vector/Vlib/net.c
*****************************************************************
Function
Vect_net_build_graph(Begins at: 90, Ends at:442)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 51 | | OK | 51 |
ParamNBR: | 9 | * | WARNING | 9 |
CalledNBR: | 126 | * | WARNING | 126 |
LOC: | 353 | | OK | 353 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Vect_net_get_line_cost(Begins at: 551, Ends at:594)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | *** | MONSTER | 5 |
ParamNBR: | 4 | *** | MONSTER | 4 |
CalledNBR: | 4 | *** | MONSTER | 4 |
LOC: | 44 | *** | MONSTER | 44 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_net_get_node_cost(Begins at: 605, Ends at:614)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 10 | * | WARNING | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
Vect_net_nearest_nodes(Begins at: 634, Ends at:832)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 45 | | OK | 45 |
ParamNBR: | 14 | * | WARNING | 14 |
CalledNBR: | 39 | | OK | 39 |
LOC: | 199 | | OK | 199 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Vect_net_shortest_path(Begins at: 463, Ends at:537)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | *** | MONSTER | 13 |
ParamNBR: | 5 | *** | MONSTER | 5 |
CalledNBR: | 12 | *** | MONSTER | 12 |
LOC: | 75 | *** | MONSTER | 75 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Vect_net_shortest_path_coor(Begins at: 852, Ends at:1055)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 34 | ** | BABY-MONSTER | 34 |
ParamNBR: | 16 | * | WARNING | 16 |
CalledNBR: | 47 | * | WARNING | 47 |
LOC: | 204 | * | WARNING | 204 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
clipper(Begins at: 30, Ends at:65)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | *** | MONSTER | 4 |
ParamNBR: | 4 | *** | MONSTER | 4 |
CalledNBR: | 12 | *** | MONSTER | 12 |
LOC: | 36 | *** | MONSTER | 36 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/net.c clones of clipper are:
/var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/graph.c clipper
____________________________________________
Threshold grass key metrics values at Fri Feb 27 09:43:19 EST 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list