[GRASS-QA] GRASS QA: martinl |Gs3.c main.c | no clones | 0 monsters |0 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Tue Jun 30 16:57:01 EDT 2009


Hello martinl,

here's a report on your recent GRASS-SVN change : 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :grass/trunk/lib/ogsf/Gs3.c
*****************************************************************

          Function
Gs_build_256lookup(Begins at: 623, Ends at:670)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |     * |      WARNING |         6 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      11 |     * |      WARNING |        11 |
LOC:          |      48 |     * |      WARNING |        48 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Gs_distance(Begins at: 84, Ends at:94)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      11 |       |           OK |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Gs_get_cat_label(Begins at: 819, Ends at:884)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |     * |      WARNING |         8 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      27 |    ** | BABY-MONSTER |        27 |
LOC:          |      66 |     * |      WARNING |        66 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Gs_load_3dview(Begins at: 996, Ends at:1121)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |     * |      WARNING |        16 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      11 |     * |      WARNING |        11 |
LOC:          |     126 |     * |      WARNING |       126 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 4 values are close to an outlier please consider revising code!


Gs_loadmap_as_bitmap(Begins at: 555, Ends at:609)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |     * |      WARNING |         8 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      21 |    ** | BABY-MONSTER |        21 |
LOC:          |      55 |     * |      WARNING |        55 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Gs_loadmap_as_char(Begins at: 446, Ends at:534)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      23 |     * |      WARNING |        23 |
LOC:          |      89 |     * |      WARNING |        89 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 4 values are close to an outlier please consider revising code!


Gs_loadmap_as_float(Begins at: 114, Ends at:166)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      21 |     * |      WARNING |        21 |
LOC:          |      53 |     * |      WARNING |        53 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 4 values are close to an outlier please consider revising code!


Gs_loadmap_as_int(Begins at: 188, Ends at:239)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |     * |      WARNING |         7 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      19 |    ** | BABY-MONSTER |        19 |
LOC:          |      52 |     * |      WARNING |        52 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Gs_loadmap_as_short(Begins at: 332, Ends at:418)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      10 |    ** | BABY-MONSTER |        10 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      25 |     * |      WARNING |        25 |
LOC:          |      87 |    ** | BABY-MONSTER |        87 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Gs_numtype(Begins at: 250, Ends at:310)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      61 |     * |      WARNING |        61 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Gs_pack_colors(Begins at: 683, Ends at:734)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      17 |     * |      WARNING |        17 |
LOC:          |      52 |     * |      WARNING |        52 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Gs_pack_colors_float(Begins at: 750, Ends at:804)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      17 |     * |      WARNING |        17 |
LOC:          |      55 |     * |      WARNING |        55 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Gs_save_3dview(Begins at: 898, Ends at:983)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |     * |      WARNING |         8 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      12 |     * |      WARNING |        12 |
LOC:          |      86 |     * |      WARNING |        86 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 4 values are close to an outlier please consider revising code!


Gs_update_attrange(Begins at: 1132, Ends at:1242)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |       |           OK |        13 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      12 |       |           OK |        12 |
LOC:          |     111 |       |           OK |       111 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :grass/trunk/raster/r.colors.out/main.c
*****************************************************************

          Function
main(Begins at: 42, Ends at:143)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |       |           OK |         9 |
ParamNBR:     |       2 |     * |      WARNING |         2 |
CalledNBR:    |      34 |       |           OK |        34 |
LOC:          |     102 |       |           OK |       102 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


write_rule(Begins at: 27, Ends at:40)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |     * |      WARNING |         3 |
ParamNBR:     |       4 |       |           OK |         4 |
CalledNBR:    |       2 |    ** | BABY-MONSTER |         2 |
LOC:          |      14 |    ** | BABY-MONSTER |        14 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Tue Jun 30 16:44:49 EDT 2009 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         6 |        13 |        21 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        10 |        23 |        37 |
LOC:                  |        42 |        91 |       141 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list