[GRASS-QA] GRASS QA: martinl |raster.h closecell.c get_row.c
zero_cell.c ...| 6 clones | 0 monsters |0 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Tue Jun 30 17:59:05 EDT 2009
Hello martinl,
here's a report on your recent GRASS-SVN change :
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :grass/trunk/include/raster.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/raster/closecell.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/raster/get_row.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/lib/raster/zero_cell.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :grass/trunk/raster/r.le/r.le.patch/driver.c
*****************************************************************
Function
fopen0(Begins at: 438, Ends at:452)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 15 | | OK | 15 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
fopen1(Begins at: 458, Ends at:482)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
fopen2(Begins at: 487, Ends at:509)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
free_para(Begins at: 2434, Ends at:2454)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
get_para(Begins at: 2330, Ends at:2424)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 12 | * | WARNING | 12 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 29 | ** | BABY-MONSTER | 29 |
LOC: | 95 | ** | BABY-MONSTER | 95 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
meter(Begins at: 2286, Ends at:2324)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
mv_driver(Begins at: 515, Ends at:2222)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 480 | *** | MONSTER | 480 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 759 | *** | MONSTER | 759 |
LOC: | 1708 | *** | MONSTER | 1708 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
open_files(Begins at: 139, Ends at:431)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 52 | *** | MONSTER | 52 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 160 | *** | MONSTER | 160 |
LOC: | 293 | *** | MONSTER | 293 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
patch_fore(Begins at: 66, Ends at:131)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 22 | * | WARNING | 22 |
LOC: | 66 | * | WARNING | 66 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
read_line(Begins at: 2540, Ends at:2578)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
read_mwind(Begins at: 2250, Ends at:2278)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 29 | | OK | 29 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
read_para(Begins at: 2464, Ends at:2532)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 69 | * | WARNING | 69 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
run_clip(Begins at: 2738, Ends at:2796)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 59 | * | WARNING | 59 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
set_colors(Begins at: 2232, Ends at:2242)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 11 | | OK | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
unit_driver(Begins at: 2588, Ends at:2729)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 30 | *** | MONSTER | 30 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 51 | *** | MONSTER | 51 |
LOC: | 142 | *** | MONSTER | 142 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
whole_reg_driver(Begins at: 2803, Ends at:2881)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | ** | BABY-MONSTER | 16 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 79 | * | WARNING | 79 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 6 potentially cloned functions:
fopen2 fopen3 meter2 read_mwind set_colors
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.patch/driver.c clones of fopen1 are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c fopen1
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.patch/driver.c clones of fopen2 are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c fopen2
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c fopen3
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.patch/driver.c clones of meter are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c meter2
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.patch/driver.c clones of read_mwind are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c read_mwind
In /var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.patch/driver.c clones of set_colors are:
/var/project-manager/grass/grassSVN/grass/trunk/raster/r.le/r.le.pixel/driver.c set_colors
*****************************************************************
File :grass/trunk/raster/r.le/r.le.patch/trace.c
*****************************************************************
Function
cell_clip(Begins at: 454, Ends at:779)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 54 | *** | MONSTER | 54 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 55 | *** | MONSTER | 55 |
LOC: | 326 | *** | MONSTER | 326 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
cell_clip_drv(Begins at: 38, Ends at:444)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 64 | *** | MONSTER | 64 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 94 | *** | MONSTER | 94 |
LOC: | 407 | *** | MONSTER | 407 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
clockwise(Begins at: 1821, Ends at:1828)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get_bd(Begins at: 907, Ends at:1668)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 133 | *** | MONSTER | 133 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 45 | *** | MONSTER | 45 |
LOC: | 762 | *** | MONSTER | 762 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
trace(Begins at: 790, Ends at:895)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 106 | ** | BABY-MONSTER | 106 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
yes_nb(Begins at: 1683, Ends at:1812)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | ** | BABY-MONSTER | 17 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 130 | ** | BABY-MONSTER | 130 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.le/r.le.pixel/cellclip.c
*****************************************************************
Function
cell_clip(Begins at: 224, Ends at:443)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 32 | *** | MONSTER | 32 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 43 | *** | MONSTER | 43 |
LOC: | 220 | *** | MONSTER | 220 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
cell_clip_drv(Begins at: 33, Ends at:160)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | ** | BABY-MONSTER | 15 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 30 | ** | BABY-MONSTER | 30 |
LOC: | 128 | ** | BABY-MONSTER | 128 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
center_is_not_null(Begins at: 198, Ends at:216)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
compar(Begins at: 486, Ends at:489)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 4 | | OK | 4 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get_rich(Begins at: 454, Ends at:478)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
is_not_empty_buffer(Begins at: 170, Ends at:190)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 21 | | OK | 21 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.le/r.le.pixel/driver.c
*****************************************************************
Function
fopen0(Begins at: 1117, Ends at:1132)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 16 | | OK | 16 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
fopen1(Begins at: 1140, Ends at:1164)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 10 | * | WARNING | 10 |
LOC: | 25 | | OK | 25 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
fopen2(Begins at: 1170, Ends at:1192)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
fopen3(Begins at: 1198, Ends at:1220)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 23 | | OK | 23 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get_rich_whole(Begins at: 1826, Ends at:1851)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 26 | | OK | 26 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
meter2(Begins at: 1228, Ends at:1267)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | * | WARNING | 6 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 40 | | OK | 40 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
mv_driver(Begins at: 156, Ends at:1088)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 228 | *** | MONSTER | 228 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 355 | *** | MONSTER | 355 |
LOC: | 933 | *** | MONSTER | 933 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
read_mwind(Begins at: 1273, Ends at:1302)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
run_clip(Begins at: 1561, Ends at:1621)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 9 | * | WARNING | 9 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 12 | * | WARNING | 12 |
LOC: | 61 | * | WARNING | 61 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
set_colors(Begins at: 1099, Ends at:1108)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
texture_fore(Begins at: 46, Ends at:149)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 13 | ** | BABY-MONSTER | 13 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 41 | *** | MONSTER | 41 |
LOC: | 104 | ** | BABY-MONSTER | 104 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
unit_driver(Begins at: 1308, Ends at:1551)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 53 | *** | MONSTER | 53 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 72 | *** | MONSTER | 72 |
LOC: | 244 | *** | MONSTER | 244 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
whole_reg_driver(Begins at: 1631, Ends at:1814)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 39 | *** | MONSTER | 39 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 37 | *** | MONSTER | 37 |
LOC: | 184 | *** | MONSTER | 184 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.le/r.le.pixel/texture.c
*****************************************************************
Function
cal_att(Begins at: 610, Ends at:663)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 7 | * | WARNING | 7 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 54 | * | WARNING | 54 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
cal_divers(Begins at: 670, Ends at:737)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 5 | | OK | 5 |
LOC: | 68 | * | WARNING | 68 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
cal_edge(Begins at: 898, Ends at:1190)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 35 | *** | MONSTER | 35 |
ParamNBR: | 15 | *** | MONSTER | 15 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 293 | *** | MONSTER | 293 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
cal_tex(Begins at: 747, Ends at:892)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 30 | *** | MONSTER | 30 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 146 | *** | MONSTER | 146 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
check_order(Begins at: 1363, Ends at:1371)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 9 | | OK | 9 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
df_texture(Begins at: 249, Ends at:602)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 71 | *** | MONSTER | 71 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 99 | *** | MONSTER | 99 |
LOC: | 354 | *** | MONSTER | 354 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
find_edge(Begins at: 1342, Ends at:1355)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
find_loc(Begins at: 1321, Ends at:1333)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
mv_texture(Begins at: 55, Ends at:241)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 38 | *** | MONSTER | 38 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 25 | ** | BABY-MONSTER | 25 |
LOC: | 187 | *** | MONSTER | 187 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
read_edge(Begins at: 1257, Ends at:1309)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 53 | * | WARNING | 53 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
read_weight(Begins at: 1197, Ends at:1248)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | * | WARNING | 8 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 15 | * | WARNING | 15 |
LOC: | 52 | * | WARNING | 52 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.le/r.le.setup/sample.c
*****************************************************************
Function
calc_num(Begins at: 1138, Ends at:1165)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 4 | | OK | 4 |
ParamNBR: | 11 | *** | MONSTER | 11 |
CalledNBR: | 4 | | OK | 4 |
LOC: | 28 | | OK | 28 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
calc_unit_loc(Begins at: 821, Ends at:1094)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 33 | *** | MONSTER | 33 |
ParamNBR: | 22 | *** | MONSTER | 22 |
CalledNBR: | 50 | *** | MONSTER | 50 |
LOC: | 274 | *** | MONSTER | 274 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
draw_box(Begins at: 1615, Ends at:1644)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 30 | | OK | 30 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 2 values are close to an outlier please consider revising code!
draw_circle(Begins at: 1649, Ends at:1689)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 7 | | OK | 7 |
LOC: | 41 | | OK | 41 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
draw_grid(Begins at: 748, Ends at:816)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 10 | *** | MONSTER | 10 |
CalledNBR: | 8 | | OK | 8 |
LOC: | 69 | * | WARNING | 69 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
f(Begins at: 1117, Ends at:1122)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get_rd(Begins at: 1099, Ends at:1112)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
graph_unit(Begins at: 1173, Ends at:1610)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 36 | *** | MONSTER | 36 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 116 | *** | MONSTER | 116 |
LOC: | 438 | *** | MONSTER | 438 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
man_unit(Begins at: 134, Ends at:743)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 62 | *** | MONSTER | 62 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 157 | *** | MONSTER | 157 |
LOC: | 610 | *** | MONSTER | 610 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
numtrap(Begins at: 1694, Ends at:1763)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 11 | * | WARNING | 11 |
LOC: | 70 | * | WARNING | 70 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
overlap(Begins at: 1127, Ends at:1133)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 7 | | OK | 7 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
sample(Begins at: 57, Ends at:128)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 16 | * | WARNING | 16 |
LOC: | 72 | * | WARNING | 72 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.le/r.le.trace/main.c
*****************************************************************
Function
cell_clip(Begins at: 502, Ends at:727)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 37 | *** | MONSTER | 37 |
ParamNBR: | 8 | ** | BABY-MONSTER | 8 |
CalledNBR: | 37 | *** | MONSTER | 37 |
LOC: | 226 | *** | MONSTER | 226 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
cell_clip_drv(Begins at: 377, Ends at:495)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 5 | | OK | 5 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 14 | * | WARNING | 14 |
LOC: | 119 | ** | BABY-MONSTER | 119 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
clockwise(Begins at: 1655, Ends at:1662)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
draw_patch(Begins at: 334, Ends at:352)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
get_bd(Begins at: 850, Ends at:1502)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 97 | *** | MONSTER | 97 |
ParamNBR: | 9 | *** | MONSTER | 9 |
CalledNBR: | 43 | *** | MONSTER | 43 |
LOC: | 653 | *** | MONSTER | 653 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
main(Begins at: 40, Ends at:106)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 33 | ** | BABY-MONSTER | 33 |
LOC: | 67 | * | WARNING | 67 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
patch_attr(Begins at: 282, Ends at:325)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 3 | ** | BABY-MONSTER | 3 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 44 | | OK | 44 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
scr_cell(Begins at: 362, Ends at:367)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
set_map(Begins at: 115, Ends at:147)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | *** | MONSTER | 1 |
ParamNBR: | 7 | * | WARNING | 7 |
CalledNBR: | 9 | *** | MONSTER | 9 |
LOC: | 33 | ** | BABY-MONSTER | 33 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
show_patch(Begins at: 157, Ends at:277)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 24 | * | WARNING | 24 |
ParamNBR: | 3 | * | WARNING | 3 |
CalledNBR: | 48 | | OK | 48 |
LOC: | 121 | ** | BABY-MONSTER | 121 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
trace(Begins at: 735, Ends at:838)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | ** | BABY-MONSTER | 8 |
ParamNBR: | 5 | ** | BABY-MONSTER | 5 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 104 | ** | BABY-MONSTER | 104 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
yes_nb(Begins at: 1517, Ends at:1646)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 17 | * | WARNING | 17 |
ParamNBR: | 8 | * | WARNING | 8 |
CalledNBR: | 2 | * | WARNING | 2 |
LOC: | 130 | * | WARNING | 130 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 4 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :grass/trunk/raster/r.random.cells/init.c
*****************************************************************
Function
Init(Begins at: 14, Ends at:112)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 19 | | OK | 19 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 36 | | OK | 36 |
LOC: | 99 | | OK | 99 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
comp_array(Begins at: 115, Ends at:125)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | ** | BABY-MONSTER | 3 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 0 | ** | BABY-MONSTER | 0 |
LOC: | 11 | ** | BABY-MONSTER | 11 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Tue Jun 30 17:46:51 EDT 2009 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 6 | 13 | 21 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 10 | 23 | 37 |
LOC: | 42 | 91 | 141 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list