[GRASS-QA] GRASS QA: ychemin |gain_aster.c rad2ref_aster.c main.c | 3 clones | 2 monsters |1 warnings

[soccerlab.info at gmail.com]

Hello ychemin,

here's a report on your recent grass-SVN change for the revision : 44567 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/imagery/i.aster.toar/gain_aster.c
*****************************************************************

          Function
gain_aster(Begins at: 6, Ends at:152)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      46 |   *** |      MONSTER |        46 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       0 |       |           OK |         0 |
LOC:          |     147 |     * |      WARNING |       147 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/imagery/i.aster.toar/rad2ref_aster.c
*****************************************************************

          Function
rad2ref_aster(Begins at: 8, Ends at:18)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      11 |       |           OK |        11 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file has 3 potentially cloned functions:
  rad2ref_landsat7  rad2ref_aster

In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.aster.toar/rad2ref_aster.c clones of rad2ref_aster are:
          /data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/i.dn2potrad.l5/rad2ref_landsat5.c  rad2ref_landsat5
          /data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/i.dn2potrad.l7/rad2ref_landsat7.c  rad2ref_landsat7
          /data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/i.dn2ref.ast/rad2ref_aster.c  rad2ref_aster

*****************************************************************
          File :/imagery/i.aster.toar/main.c
*****************************************************************

          Function
main(Begins at: 50, Ends at:327)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      23 |    ** | BABY-MONSTER |        23 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     100 |   *** |      MONSTER |       100 |
LOC:          |     278 |   *** |      MONSTER |       278 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Wed Dec 08 23:00:46 EST 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |        10 |        22 |        34 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        18 |        43 |        69 |
LOC:                  |        68 |       153 |       239 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html