[GRASS-QA] GRASS QA: mmetz |r.univar_main.c stats.c r3.univar_main.c | no clones | 1 monsters |3 warnings

[soccerlab.info at gmail.com]

Hello mmetz,

here's a report on your recent grass-SVN change for the revision : 43815 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/raster/r.univar/r.univar_main.c
*****************************************************************

          Function
main(Begins at: 80, Ends at:206)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      19 |    ** | BABY-MONSTER |        19 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      43 |    ** | BABY-MONSTER |        43 |
LOC:          |     127 |     * |      WARNING |       127 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/raster/r.univar/stats.c
*****************************************************************

          Function
print_stats_table(Begins at: 298, Ends at:494)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      24 |    ** | BABY-MONSTER |        24 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      56 |    ** | BABY-MONSTER |        56 |
LOC:          |     197 |    ** | BABY-MONSTER |       197 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


print_stats(Begins at: 105, Ends at:296)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      29 |    ** | BABY-MONSTER |        29 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      54 |    ** | BABY-MONSTER |        54 |
LOC:          |     192 |    ** | BABY-MONSTER |       192 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/raster/r.univar/r3.univar_main.c
*****************************************************************

          Function
main(Begins at: 77, Ends at:308)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      43 |   *** |      MONSTER |        43 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      64 |    ** | BABY-MONSTER |        64 |
LOC:          |     232 |    ** | BABY-MONSTER |       232 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Tue Nov 02 23:01:19 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        18 |        43 |        69 |
LOC:                  |        67 |       151 |       235 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html