[GRASS-QA] GRASS QA: glynn |main.c | 5 clones | 0 monsters |1 warnings

[soccerlab.info at gmail.com]

Hello glynn,

here's a report on your recent grass-SVN change for the revision : 43853 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/raster/r.series/main.c
*****************************************************************

          Class
input(Begins at: 57, Ends at:62)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |        |        |        |        |        |        |
+------------+--------+--------+--------+--------+--------+--------+



          Class
menu(Begins at: 25, Ends at:55)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |        |        |        |        |        |        |
+------------+--------+--------+--------+--------+--------+--------+



          Class
output(Begins at: 64, Ends at:71)
             +--------+--------+--------+--------+--------+--------+
             |    DIT |    NOC |    WMC |    RFC |    CBO |   LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics |      1 |      0 |      0 |      0 |      0 |      0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics |        |        |        |        |        |        |
+------------+--------+--------+--------+--------+--------+--------+



          Function
main(Begins at: 105, Ends at:288)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      21 |    ** | BABY-MONSTER |        21 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      59 |    ** | BABY-MONSTER |        59 |
LOC:          |     184 |    ** | BABY-MONSTER |       184 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


build_method_list(Begins at: 73, Ends at:90)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      18 |       |           OK |        18 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 5 potentially cloned functions:
  build_filter_list  build_method_list  build_method_list  build_method_list

In /data/project-manager/grass/grassSVN/grass/trunk/raster/r.series/main.c clones of main are:
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.series/main.c  main

In /data/project-manager/grass/grassSVN/grass/trunk/raster/r.series/main.c clones of build_method_list are:
          /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.filter/main.c  build_filter_list
          /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.stats/main.c  build_method_list
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.stats/main.c  build_method_list
          /var/project-manager/grass/grassSVN/grass/trunk/raster/r.series/main.c  build_method_list

____________________________________________


Threshold grass key metrics values at Wed Nov 03 00:32:43 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        18 |        43 |        69 |
LOC:                  |        67 |       151 |       235 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html