[GRASS-QA] GRASS QA: mmetz |crosscorr.c main.c | 2 clones | 2 monsters |0 warnings

[soccerlab.info at gmail.com]

Hello mmetz,

here's a report on your recent grass-SVN change for the revision : 43485 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/raster/r.resamp.bspline/crosscorr.c
*****************************************************************

          Function
cross_correlation(Begins at: 120, Ends at:338)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      67 |   *** |      MONSTER |        67 |
LOC:          |     219 |    ** | BABY-MONSTER |       219 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file has 1 potentially cloned functions:


In /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/crosscorr.c clones of cross_correlation are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/crosscorr.c  cross_correlation

*****************************************************************
          File :/raster/r.resamp.bspline/main.c
*****************************************************************

          Function
main(Begins at: 27, Ends at:688)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      54 |   *** |      MONSTER |        54 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |     235 |   *** |      MONSTER |       235 |
LOC:          |     662 |   *** |      MONSTER |       662 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file has 1 potentially cloned functions:


In /data/project-manager/grass/grassSVN/grass/trunk/raster/r.resamp.bspline/main.c clones of main are:
          /data/project-manager/grass/grassSVN/grass/trunk/vector/lidar/r.resamp.bspline/main.c  main

____________________________________________


Threshold grass key metrics values at Fri Sep 17 09:01:46 EDT 2010 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        66 |       150 |       234 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html