[GRASS-QA] GRASS QA: martinl |cats.c distance.c copy.c render.c ...| no clones | 2 monsters |15 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Sat Jan 8 21:52:48 EST 2011


Hello martinl,

here's a report on your recent grass-SVN change for the revision : 44910 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/lib/vector/vedit/cats.c
*****************************************************************

          Function
Vedit_modify_cats(Begins at: 31, Ends at:95)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      11 |       |           OK |        11 |
LOC:          |      65 |     * |      WARNING |        65 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/distance.c
*****************************************************************

          Function
Vedit_get_min_distance(Begins at: 27, Ends at:77)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      51 |       |           OK |        51 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/copy.c
*****************************************************************

          Function
Vedit_copy_lines(Begins at: 27, Ends at:67)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      41 |       |           OK |        41 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/render.c
*****************************************************************

          Function
Vedit_render_map(Begins at: 61, Ends at:141)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      10 |     * |      WARNING |        10 |
ParamNBR:     |       8 |    ** | BABY-MONSTER |         8 |
CalledNBR:    |      18 |     * |      WARNING |        18 |
LOC:          |      81 |     * |      WARNING |        81 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/zbulk.c
*****************************************************************

          Function
Vedit_bulk_labeling(Begins at: 33, Ends at:136)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       8 |    ** | BABY-MONSTER |         8 |
CalledNBR:    |      20 |     * |      WARNING |        20 |
LOC:          |     104 |     * |      WARNING |       104 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/chtype.c
*****************************************************************

          Function
Vedit_chtype_lines(Begins at: 29, Ends at:83)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      55 |       |           OK |        55 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/vertex.c
*****************************************************************

          Function
Vedit_move_vertex(Begins at: 33, Ends at:177)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      21 |    ** | BABY-MONSTER |        21 |
ParamNBR:     |      12 |   *** |      MONSTER |        12 |
CalledNBR:    |      18 |     * |      WARNING |        18 |
LOC:          |     145 |     * |      WARNING |       145 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Vedit_remove_vertex(Begins at: 282, Ends at:350)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      10 |       |           OK |        10 |
LOC:          |      69 |     * |      WARNING |        69 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Vedit_add_vertex(Begins at: 194, Ends at:267)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      13 |       |           OK |        13 |
LOC:          |      74 |     * |      WARNING |        74 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/delete.c
*****************************************************************

          Function
Vedit_delete_lines(Begins at: 25, Ends at:47)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |      23 |       |           OK |        23 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/merge.c
*****************************************************************

          Function
Vedit_merge_lines(Begins at: 47, Ends at:179)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      18 |     * |      WARNING |        18 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      27 |     * |      WARNING |        27 |
LOC:          |     133 |     * |      WARNING |       133 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/flip.c
*****************************************************************

          Function
Vedit_flip_lines(Begins at: 25, Ends at:64)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      40 |       |           OK |        40 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/select.c
*****************************************************************

          Function
Vedit_select_by_query(Begins at: 42, Ends at:124)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |     * |      WARNING |        16 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |      21 |     * |      WARNING |        21 |
LOC:          |      83 |     * |      WARNING |        83 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


select_by_query(Begins at: 133, Ends at:235)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      18 |     * |      WARNING |        18 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |      23 |     * |      WARNING |        23 |
LOC:          |     103 |     * |      WARNING |       103 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/snap.c
*****************************************************************

          Function
Vedit_snap_line(Begins at: 99, Ends at:160)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      62 |       |           OK |        62 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Vedit_snap_lines(Begins at: 175, Ends at:210)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      36 |       |           OK |        36 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Vedit_snap_point(Begins at: 28, Ends at:82)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       7 |    ** | BABY-MONSTER |         7 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      55 |       |           OK |        55 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/move.c
*****************************************************************

          Function
Vedit_move_lines(Begins at: 29, Ends at:95)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      10 |     * |      WARNING |        10 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      67 |     * |      WARNING |        67 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/lib/vector/vedit/break.c
*****************************************************************

          Function
Vedit_split_lines(Begins at: 32, Ends at:130)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |     * |      WARNING |        13 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      23 |     * |      WARNING |        23 |
LOC:          |      99 |     * |      WARNING |        99 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 4 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Sat Jan 08 21:52:35 EST 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        65 |       146 |       227 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list