[GRASS-QA] GRASS QA: martinl |render.c | no clones | 0 monsters |4 warnings

[soccerlab.info at gmail.com]

Hello martinl,

here's a report on your recent grass-SVN change for the revision : 44907 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/lib/vector/vedit/render.c
*****************************************************************

          Function
draw_line_nodes(Begins at: 242, Ends at:279)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |       |           OK |         6 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      38 |       |           OK |        38 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


draw_arrow(Begins at: 414, Ends at:435)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       8 |    ** | BABY-MONSTER |         8 |
CalledNBR:    |       6 |       |           OK |         6 |
LOC:          |      22 |       |           OK |        22 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


draw_line_dir(Begins at: 334, Ends at:397)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      10 |       |           OK |        10 |
LOC:          |      64 |       |           OK |        64 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Vedit_render_map(Begins at: 61, Ends at:141)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      10 |     * |      WARNING |        10 |
ParamNBR:     |       8 |    ** | BABY-MONSTER |         8 |
CalledNBR:    |      18 |     * |      WARNING |        18 |
LOC:          |      81 |     * |      WARNING |        81 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Sat Jan 08 12:53:53 EST 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        65 |       146 |       227 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html