[GRASS-QA] GRASS QA: ychemin |pt_delta.c main.c pt_ghamma.c pt_daily_et.c | 2 clones | 0 monsters |2 warnings

[soccerlab.info at gmail.com]

Hello ychemin,

here's a report on your recent grass-SVN change for the revision : 44977 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/imagery/i.evapo.PT/pt_delta.c
*****************************************************************

          Function
pt_delta(Begins at: 8, Ends at:17)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 1 potentially cloned functions:


In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.PT/pt_delta.c clones of pt_delta are:
          /data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/i.evapo.PT/pt_delta.c  pt_delta

*****************************************************************
          File :/imagery/i.evapo.PT/main.c
*****************************************************************

          Function
main(Begins at: 30, Ends at:215)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |       |           OK |         6 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      64 |    ** | BABY-MONSTER |        64 |
LOC:          |     186 |    ** | BABY-MONSTER |       186 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/imagery/i.evapo.PT/pt_ghamma.c
*****************************************************************

          Function
pt_ghamma(Begins at: 8, Ends at:17)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |      10 |       |           OK |        10 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 1 potentially cloned functions:


In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.PT/pt_ghamma.c clones of pt_ghamma are:
          /data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/i.evapo.PT/pt_ghamma.c  pt_ghamma

*****************************************************************
          File :/imagery/i.evapo.PT/pt_daily_et.c
*****************************************************************

          Function
pt_daily_et(Begins at: 6, Ends at:24)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       6 |    ** | BABY-MONSTER |         6 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      19 |       |           OK |        19 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Tue Jan 11 23:37:14 EST 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        66 |       148 |       231 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html