[GRASS-QA] GRASS QA: ychemin |mh_eto.c main.c mh_original.c mh_samani.c | 7 clones | 1 monsters |3 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Wed Jan 12 00:30:14 EST 2011


Hello ychemin,

here's a report on your recent grass-SVN change for the revision : 44979 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/imagery/i.evapo.MH/mh_eto.c
*****************************************************************

          Function
mh_eto(Begins at: 7, Ends at:19)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      13 |       |           OK |        13 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file has 3 potentially cloned functions:
  mh_original  mh_original

In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.MH/mh_eto.c clones of mh_eto are:
          /data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/r.evapo.MH/mh_eto.c  mh_eto
          /data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/r.evapo.MH/mh_original.c  mh_original
          /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.MH/mh_original.c  mh_original

*****************************************************************
          File :/imagery/i.evapo.MH/main.c
*****************************************************************

          Function
main(Begins at: 32, Ends at:251)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |     * |      WARNING |        16 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      79 |   *** |      MONSTER |        79 |
LOC:          |     220 |    ** | BABY-MONSTER |       220 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/imagery/i.evapo.MH/mh_original.c
*****************************************************************

          Function
mh_original(Begins at: 6, Ends at:17)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      12 |       |           OK |        12 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file has 3 potentially cloned functions:
  mh_original  mh_eto

In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.MH/mh_original.c clones of mh_original are:
          /data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/r.evapo.MH/mh_eto.c  mh_eto
          /data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/r.evapo.MH/mh_original.c  mh_original
          /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.MH/mh_eto.c  mh_eto

*****************************************************************
          File :/imagery/i.evapo.MH/mh_samani.c
*****************************************************************

          Function
mh_samani(Begins at: 6, Ends at:19)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |      14 |       |           OK |        14 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file has 1 potentially cloned functions:


In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.MH/mh_samani.c clones of mh_samani are:
          /data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/r.evapo.MH/mh_samani.c  mh_samani

____________________________________________


Threshold grass key metrics values at Wed Jan 12 00:30:02 EST 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        19 |        30 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        66 |       148 |       231 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list