[GRASS-QA] GRASS QA: |mh_samani.c pt_daily_et.c pt_delta.c main.c
...| 11 clones | 3 monsters |7 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Wed Jan 12 10:53:23 EST 2011
Hello ,
here's a report on your recent grass-SVN change for the revision : 44987
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/imagery/i.evapo.mh/mh_samani.c
*****************************************************************
Function
mh_samani(Begins at: 6, Ends at:19)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 4 | * | WARNING | 4 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 14 | | OK | 14 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.MH/mh_samani.c clones of mh_samani are:
/data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/r.evapo.MH/mh_samani.c mh_samani
*****************************************************************
File :/imagery/i.evapo.pt/pt_daily_et.c
*****************************************************************
Function
pt_daily_et(Begins at: 6, Ends at:24)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 6 | ** | BABY-MONSTER | 6 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 19 | | OK | 19 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.pt/pt_daily_et.c clones of pt_daily_et are:
/data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.PT/pt_daily_et.c pt_daily_et
*****************************************************************
File :/imagery/i.evapo.pt/pt_delta.c
*****************************************************************
Function
pt_delta(Begins at: 8, Ends at:17)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.PT/pt_delta.c clones of pt_delta are:
/data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/i.evapo.PT/pt_delta.c pt_delta
*****************************************************************
File :/imagery/i.evapo.time/main.c
*****************************************************************
Function
main(Begins at: 26, Ends at:414)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 49 | *** | MONSTER | 49 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 99 | *** | MONSTER | 99 |
LOC: | 389 | *** | MONSTER | 389 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/imagery/i.evapo.pm/functions.c
*****************************************************************
Function
calc_ETp(Begins at: 31, Ends at:102)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 3 | | OK | 3 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 6 | | OK | 6 |
LOC: | 72 | * | WARNING | 72 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
calc_openwaterETp(Begins at: 104, Ends at:142)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 7 | ** | BABY-MONSTER | 7 |
CalledNBR: | 3 | | OK | 3 |
LOC: | 39 | | OK | 39 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 2 potentially cloned functions:
calc_openwaterETp
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.PM/functions.c clones of calc_ETp are:
/data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/r.evapo.PM/functions.c calc_ETp
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.pm/functions.c clones of calc_openwaterETp are:
/data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.PM/functions.c calc_openwaterETp
*****************************************************************
File :/imagery/i.evapo.pm/local_proto.h
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/imagery/i.evapo.mh/mh_original.c
*****************************************************************
Function
mh_original(Begins at: 6, Ends at:17)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 12 | | OK | 12 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.MH/mh_original.c clones of mh_original are:
/data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/r.evapo.MH/mh_eto.c mh_eto
*****************************************************************
File :/imagery/i.evapo.pt/main.c
*****************************************************************
Function
main(Begins at: 30, Ends at:215)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 6 | | OK | 6 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 64 | ** | BABY-MONSTER | 64 |
LOC: | 186 | ** | BABY-MONSTER | 186 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.pt/main.c clones of main are:
/data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.PT/main.c main
*****************************************************************
File :/imagery/i.evapo.pm/main.c
*****************************************************************
Function
main(Begins at: 29, Ends at:242)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 8 | | OK | 8 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 75 | *** | MONSTER | 75 |
LOC: | 214 | ** | BABY-MONSTER | 214 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.pm/main.c clones of main are:
/data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.PM/main.c main
*****************************************************************
File :/imagery/i.evapo.mh/main.c
*****************************************************************
Function
main(Begins at: 32, Ends at:251)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 16 | * | WARNING | 16 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 79 | *** | MONSTER | 79 |
LOC: | 220 | ** | BABY-MONSTER | 220 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.mh/main.c clones of main are:
/data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.MH/main.c main
*****************************************************************
File :/imagery/i.evapo.mh/mh_eto.c
*****************************************************************
Function
mh_eto(Begins at: 7, Ends at:19)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 2 | | OK | 2 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 1 | | OK | 1 |
LOC: | 13 | | OK | 13 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.MH/mh_eto.c clones of mh_eto are:
/data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/r.evapo.MH/mh_eto.c mh_eto
*****************************************************************
File :/imagery/i.evapo.pt/pt_ghamma.c
*****************************************************************
Function
pt_ghamma(Begins at: 8, Ends at:17)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file has 1 potentially cloned functions:
In /data/project-manager/grass/grassSVN/grass/trunk/imagery/i.evapo.PT/pt_ghamma.c clones of pt_ghamma are:
/data/project-manager/grass/grassSVN/grass-addons/imagery/gipe/i.evapo.PT/pt_ghamma.c pt_ghamma
____________________________________________
Threshold grass key metrics values at Wed Jan 12 10:53:17 EST 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 17 | 41 | 65 |
LOC: | 66 | 148 | 231 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list