[GRASS-QA] GRASS QA: mmetz |cindex_rw.c update.c allocation.c
portable.c ...| no clones | 0 monsters |3 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Thu Jan 20 11:15:27 EST 2011
Hello mmetz,
here's a report on your recent grass-SVN change for the revision : 45104
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/lib/vector/diglib/cindex_rw.c
*****************************************************************
Function
dig_write_cidx_head(Begins at: 22, Ends at:109)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 15 | * | WARNING | 15 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 19 | * | WARNING | 19 |
LOC: | 88 | * | WARNING | 88 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/diglib/update.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/allocation.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/portable.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/type.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/inside.c
*****************************************************************
Function
dig_x_intersect(Begins at: 20, Ends at:29)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 10 | | OK | 10 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/diglib/prune.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/plus.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/file.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/cindex.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/poly.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/plus_struct.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/head.c
*****************************************************************
Function
dig__write_head(Begins at: 22, Ends at:79)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 10 | * | WARNING | 10 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 14 | | OK | 14 |
LOC: | 58 | | OK | 58 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 1 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/diglib/spindex_rw.c
*****************************************************************
Class
spidxstack(Begins at: 663, Ends at:668)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/diglib/plus_node.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/angle.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/box.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/frmt.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/port_init.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/list.c
*****************************************************************
Function
dig_init_list(Begins at: 22, Ends at:29)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 1 | | OK | 1 |
CalledNBR: | 0 | | OK | 0 |
LOC: | 8 | | OK | 8 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/diglib/plus_area.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/plus_line.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/spindex.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/port_test.c
*****************************************************************
Class
type_conv(Begins at: 69, Ends at:78)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | | | | | | |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/diglib/struct_alloc.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/diglib/test.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
____________________________________________
Threshold grass key metrics values at Thu Jan 20 11:15:19 EST 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 17 | 41 | 65 |
LOC: | 65 | 146 | 227 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list