[GRASS-QA] GRASS QA: mmetz |intersect.c break_polygons.c build.c
array.c ...| no clones | 1 monsters |2 warnings
soccerlab.info at gmail.com
soccerlab.info at gmail.com
Thu Jan 20 11:28:13 EST 2011
Hello mmetz,
here's a report on your recent grass-SVN change for the revision : 45105
ANALYSIS
your changes to files/class/methods/functions :
*****************************************************************
File :/lib/vector/Vlib/intersect.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/break_polygons.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/build.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/array.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/legal_vname.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/constraint.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/error.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/snap.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/poly.c
*****************************************************************
Class
Slink(Begins at: 23, Ends at:27)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Function
Vect_get_point_in_poly_isl(Begins at: 413, Ends at:536)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 26 | ** | BABY-MONSTER | 26 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 9 | | OK | 9 |
LOC: | 124 | * | WARNING | 124 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a BABY-MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/bridges.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/write_ogr.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/read_nat.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/overlay.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/cindex.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/buffer2.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/header.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/buffer.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/overlap.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/close.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/dgraph.c
*****************************************************************
Class
intersection_point(Begins at: 33, Ends at:38)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
seg_intersection(Begins at: 40, Ends at:45)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
seg_intersection_list(Begins at: 47, Ends at:52)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Class
seg_intersections(Begins at: 54, Ends at:62)
+--------+--------+--------+--------+--------+--------+
| DIT | NOC | WMC | RFC | CBO | LCOM |
+------------+--------+--------+--------+--------+--------+--------|
|NEW Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------|
|OLD Metrics | 1 | 0 | 0 | 0 | 0 | 0 |
+------------+--------+--------+--------+--------+--------+--------+
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/break_lines.c
*****************************************************************
Function
Vect_break_lines_list(Begins at: 62, Ends at:376)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 53 | *** | MONSTER | 53 |
ParamNBR: | 5 | * | WARNING | 5 |
CalledNBR: | 71 | *** | MONSTER | 71 |
LOC: | 315 | *** | MONSTER | 315 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a MONSTER |
-----------------------------------------------------------+
metric are OUT OF RANGE!
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/rewind_ogr.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/map.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/field.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/hist.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/open.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/read.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/init_head.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/clean_nodes.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/write_nat.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/select.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/open_nat.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/find.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/write.c
*****************************************************************
Function
write_dummy(Begins at: 21, Ends at:26)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 1 | | OK | 1 |
ParamNBR: | 0 | | OK | 0 |
CalledNBR: | 2 | | OK | 2 |
LOC: | 6 | | OK | 6 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a OK |
-----------------------------------------------------------+
metrics are OK
Clone analysis:
This file does not contain cloned functions
*****************************************************************
File :/lib/vector/Vlib/close_ogr.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/build_ogr.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/graph.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/dangles.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/line.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/box.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/remove_duplicates.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/close_nat.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/open_ogr.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/merge_lines.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/net.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/type.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/level_two.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/cats.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/list.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/remove_areas.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/dbcolumns.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/read_ogr.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/sindex.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/geos.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/area.c
*****************************************************************
The system don't find class, method and function
in this file during analysis!
*****************************************************************
File :/lib/vector/Vlib/build_nat.c
*****************************************************************
Function
Vect_isle_find_area(Begins at: 131, Ends at:257)
--------------+---------+-------+--------------+-----------+
| New Metrics |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity: | 11 | * | WARNING | 11 |
ParamNBR: | 2 | | OK | 2 |
CalledNBR: | 26 | * | WARNING | 26 |
LOC: | 127 | * | WARNING | 127 |
--------------+---------+-------+--------------+-----------+
Conclusion: | this function is a WARNING |
-----------------------------------------------------------+
at least 3 values are close to an outlier please consider revising code!
Clone analysis:
This file does not contain cloned functions
____________________________________________
Threshold grass key metrics values at Thu Jan 20 11:28:05 EST 2011 are:
----------------------+-----------+-----------+-----------+
| warning | middle | extrem |
| limits | limits | limits |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo): | 9 | 19 | 30 |
ParamNBR: | 3 | 6 | 9 |
CalledNBR: | 17 | 41 | 65 |
LOC: | 65 | 146 | 227 |
----------------------+-----------+-----------+-----------+
Measures (see below Web page for details) :
-Complexity (Cyclo): a complexity index
-ParamNBR: number of passed parameters
-CalledNBR: number of called functions
-LOC: Lines Of Code
-Global analysis: based on 21 metrics(the fourth preceding include)
Message interpretation :
OK : Nothing to say at all
* : this is getting close to be out of range, consider revising the code
** : this is a baby monster, you should revise this function
***: this is a monster, definitely you should revise this function
Conclusion interpretation :
CORRECT : if all metrics are situated before warning limits
WARNING : if 1 to more metrics are between warning and middle limits
BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
MONSTERS : if 1 to more metrics are in the extreme limits
_______________________________________________
Brought to you by :
SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory
Please visite our web site on your project at :
http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html
More information about the grass-qa
mailing list