[GRASS-QA] GRASS QA: martinl |strings.c gisdefs.h field.c | 1 clones | 0 monsters |2 warnings

[soccerlab.info at gmail.com]

Hello martinl,

here's a report on your recent grass-SVN change for the revision : 45541 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/lib/gis/strings.c
*****************************************************************

          Function
G_str_replace(Begins at: 136, Ends at:199)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      11 |     * |      WARNING |        11 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      14 |       |           OK |        14 |
LOC:          |      64 |     * |      WARNING |        64 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/include/gisdefs.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/lib/vector/Vlib/field.c
*****************************************************************

          Function
Vect_subst_var(Begins at: 839, Ends at:886)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      19 |     * |      WARNING |        19 |
LOC:          |      48 |       |           OK |        48 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file has 1 potentially cloned functions:


In /data/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/field.c clones of Vect_subst_var are:
          /var/project-manager/grass/grassSVN/grass/trunk/lib/vector/Vlib/field.c  Vect_subst_var

____________________________________________


Threshold grass key metrics values at Thu Mar 03 14:49:21 EST 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        16 |        38 |        61 |
LOC:                  |        64 |       145 |       226 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html