[GRASS-QA] GRASS QA: martinl |do_labels.c symbol.c main.c r_plt.c ...| 3 clones | 5 monsters |27 warnings

soccerlab.info at gmail.com soccerlab.info at gmail.com
Sat Mar 5 17:42:13 EST 2011


Hello martinl,

here's a report on your recent grass-SVN change for the revision : 45580 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/ps/ps.map/do_labels.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/symbol.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/main.c
*****************************************************************

          Function
main(Begins at: 70, Ends at:266)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |     * |      WARNING |        14 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      74 |   *** |      MONSTER |        74 |
LOC:          |     197 |    ** | BABY-MONSTER |       197 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/r_plt.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/do_header.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/r_wind.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/comment.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/ps_clrtbl.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/r_vareas.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/r_paper.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/r_group.c
*****************************************************************

          Function
read_group(Begins at: 12, Ends at:57)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |       |           OK |         6 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      19 |     * |      WARNING |        19 |
LOC:          |      46 |       |           OK |        46 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file has 1 potentially cloned functions:


In /data/project-manager/grass/grassSVN/grass/trunk/ps/ps.map/r_group.c clones of read_group are:
          /var/project-manager/grass/grassSVN/grass/trunk/ps/ps.map/r_group.c  read_group

*****************************************************************
          File :/ps/ps.map/do_scalebar.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/do_grid.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/local_proto.h
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/r_vlines.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/eps.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/outl_io.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/ps_fclrtbl.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/ps_vlegend.c
*****************************************************************

          Function
PS_vlegend(Begins at: 11, Ends at:282)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      34 |   *** |      MONSTER |        34 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      56 |    ** | BABY-MONSTER |        56 |
LOC:          |     272 |   *** |      MONSTER |       272 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/r_vlegend.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/ps_outline.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/ps_colors.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/ps_vpoints.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/getgrid.c
*****************************************************************

The system don't find class, method and function
 in this file during analysis!
*****************************************************************
          File :/ps/ps.map/do_plt.c
*****************************************************************

          Function
do_plt(Begins at: 13, Ends at:183)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      29 |    ** | BABY-MONSTER |        29 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      42 |    ** | BABY-MONSTER |        42 |
LOC:          |     171 |    ** | BABY-MONSTER |       171 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/read_key.c
*****************************************************************

          Function
read_from_keyboard(Begins at: 30, Ends at:464)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      85 |   *** |      MONSTER |        85 |
ParamNBR:     |       9 |   *** |      MONSTER |         9 |
CalledNBR:    |     140 |   *** |      MONSTER |       140 |
LOC:          |     435 |   *** |      MONSTER |       435 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/do_vectors.c
*****************************************************************

          Function
do_vectors(Begins at: 18, Ends at:121)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      19 |     * |      WARNING |        19 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      32 |     * |      WARNING |        32 |
LOC:          |     104 |     * |      WARNING |       104 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


do_vpoints(Begins at: 124, Ends at:161)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |       |           OK |         6 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |      38 |       |           OK |        38 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/map_setup.c
*****************************************************************

          Function
map_setup(Begins at: 12, Ends at:121)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       9 |       |           OK |         9 |
LOC:          |     110 |     * |      WARNING |       110 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/ps_vlines.c
*****************************************************************

          Function
PS_vlines_plot(Begins at: 19, Ends at:207)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      27 |    ** | BABY-MONSTER |        27 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      49 |    ** | BABY-MONSTER |        49 |
LOC:          |     189 |    ** | BABY-MONSTER |       189 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/r_text.c
*****************************************************************

          Function
read_text(Begins at: 44, Ends at:320)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      55 |   *** |      MONSTER |        55 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      84 |   *** |      MONSTER |        84 |
LOC:          |     277 |   *** |      MONSTER |       277 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/get_scalebar.c
*****************************************************************

          Function
read_scalebar(Begins at: 24, Ends at:153)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      27 |    ** | BABY-MONSTER |        27 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      29 |     * |      WARNING |        29 |
LOC:          |     130 |     * |      WARNING |       130 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/r_colortable.c
*****************************************************************

          Function
read_colortable(Begins at: 33, Ends at:195)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      30 |    ** | BABY-MONSTER |        30 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      41 |    ** | BABY-MONSTER |        41 |
LOC:          |     163 |    ** | BABY-MONSTER |       163 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/scale.c
*****************************************************************

          Function
OOPS(Begins at: 134, Ends at:137)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       4 |       |           OK |         4 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


do_scale(Begins at: 32, Ends at:132)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |     * |      WARNING |        16 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      29 |     * |      WARNING |        29 |
LOC:          |     101 |     * |      WARNING |       101 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


scale(Begins at: 24, Ends at:30)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |       7 |       |           OK |         7 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/r_border.c
*****************************************************************

          Function
read_border(Begins at: 21, Ends at:83)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       9 |     * |      WARNING |         9 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       7 |       |           OK |         7 |
LOC:          |      63 |       |           OK |        63 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/r_header.c
*****************************************************************

          Function
read_header(Begins at: 21, Ends at:74)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      14 |       |           OK |        14 |
LOC:          |      54 |       |           OK |        54 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/r_info.c
*****************************************************************

          Function
read_info(Begins at: 23, Ends at:100)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      16 |     * |      WARNING |        16 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      15 |       |           OK |        15 |
LOC:          |      78 |     * |      WARNING |        78 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/ps_vareas.c
*****************************************************************

          Function
PS_vareas_plot(Begins at: 128, Ends at:284)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      21 |    ** | BABY-MONSTER |        21 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      45 |    ** | BABY-MONSTER |        45 |
LOC:          |     157 |    ** | BABY-MONSTER |       157 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


construct_path(Begins at: 19, Ends at:53)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       5 |       |           OK |         5 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |       8 |       |           OK |         8 |
LOC:          |      35 |       |           OK |        35 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


get_ps_color_rgbcol_varea(Begins at: 89, Ends at:124)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      11 |       |           OK |        11 |
LOC:          |      36 |       |           OK |        36 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


plot_area(Begins at: 56, Ends at:84)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |       |           OK |         6 |
ParamNBR:     |       3 |     * |      WARNING |         3 |
CalledNBR:    |      11 |       |           OK |        11 |
LOC:          |      29 |       |           OK |        29 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/ps_map.c
*****************************************************************

          Function
ps_map(Begins at: 21, Ends at:171)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      23 |    ** | BABY-MONSTER |        23 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      44 |    ** | BABY-MONSTER |        44 |
LOC:          |     151 |    ** | BABY-MONSTER |       151 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/r_rgb.c
*****************************************************************

          Function
read_rgb(Begins at: 11, Ends at:81)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |       |           OK |         7 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      14 |       |           OK |        14 |
LOC:          |      71 |     * |      WARNING |        71 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file has 1 potentially cloned functions:


In /data/project-manager/grass/grassSVN/grass/trunk/ps/ps.map/r_rgb.c clones of read_rgb are:
          /var/project-manager/grass/grassSVN/grass/trunk/ps/ps.map/r_rgb.c  read_rgb

*****************************************************************
          File :/ps/ps.map/box.c
*****************************************************************

          Function
box_clip(Begins at: 16, Ends at:23)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


box_draw(Begins at: 34, Ends at:40)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       2 |       |           OK |         2 |
LOC:          |       7 |       |           OK |         7 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


box_fill(Begins at: 25, Ends at:32)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       1 |       |           OK |         1 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |       3 |       |           OK |         3 |
LOC:          |       8 |       |           OK |         8 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


box_path(Begins at: 8, Ends at:14)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       2 |       |           OK |         2 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |       1 |       |           OK |         1 |
LOC:          |       7 |       |           OK |         7 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/r_vpoints.c
*****************************************************************

          Function
read_vpoints(Begins at: 41, Ends at:284)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      37 |   *** |      MONSTER |        37 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      73 |   *** |      MONSTER |        73 |
LOC:          |     244 |   *** |      MONSTER |       244 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/map_info.c
*****************************************************************

          Function
map_info(Begins at: 9, Ends at:110)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      10 |     * |      WARNING |        10 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      33 |     * |      WARNING |        33 |
LOC:          |     102 |     * |      WARNING |       102 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/r_cell.c
*****************************************************************

          Function
read_cell(Begins at: 11, Ends at:42)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       4 |       |           OK |         4 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      13 |       |           OK |        13 |
LOC:          |      32 |       |           OK |        32 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file has 1 potentially cloned functions:


In /data/project-manager/grass/grassSVN/grass/trunk/ps/ps.map/r_cell.c clones of read_cell are:
          /var/project-manager/grass/grassSVN/grass/trunk/ps/ps.map/r_cell.c  read_cell

*****************************************************************
          File :/ps/ps.map/do_geogrid.c
*****************************************************************

          Function
check_coords(Begins at: 382, Ends at:440)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      13 |     * |      WARNING |        13 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      15 |       |           OK |        15 |
LOC:          |      59 |       |           OK |        59 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


do_geogrid(Begins at: 34, Ends at:133)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      15 |     * |      WARNING |        15 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      32 |     * |      WARNING |        32 |
LOC:          |     100 |     * |      WARNING |       100 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


do_geogrid_numbers(Begins at: 139, Ends at:257)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      15 |     * |      WARNING |        15 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      36 |     * |      WARNING |        36 |
LOC:          |     119 |     * |      WARNING |       119 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


get_ll_bounds(Begins at: 286, Ends at:372)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      17 |     * |      WARNING |        17 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      12 |       |           OK |        12 |
LOC:          |      87 |     * |      WARNING |        87 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 3 values are close to an outlier please consider revising code!


init_proj(Begins at: 262, Ends at:281)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       3 |       |           OK |         3 |
ParamNBR:     |       2 |       |           OK |         2 |
CalledNBR:    |      10 |       |           OK |        10 |
LOC:          |      20 |       |           OK |        20 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

*****************************************************************
          File :/ps/ps.map/ps_raster.c
*****************************************************************

          Function
PS_make_mask(Begins at: 22, Ends at:59)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |       |           OK |         7 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      10 |       |           OK |        10 |
LOC:          |      38 |       |           OK |        38 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


PS_raster_plot(Begins at: 61, Ends at:210)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      26 |    ** | BABY-MONSTER |        26 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |      42 |    ** | BABY-MONSTER |        42 |
LOC:          |     150 |    ** | BABY-MONSTER |       150 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a  BABY-MONSTER           |
-----------------------------------------------------------+
 metric are OUT OF RANGE!


ps_write_mask_row(Begins at: 213, Ends at:249)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       8 |       |           OK |         8 |
ParamNBR:     |       1 |       |           OK |         1 |
CalledNBR:    |       4 |       |           OK |         4 |
LOC:          |      37 |       |           OK |        37 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a            OK           |
-----------------------------------------------------------+
metrics are OK


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Sat Mar 05 17:41:59 EST 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        16 |        38 |        61 |
LOC:                  |        64 |       145 |       226 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html


More information about the grass-qa mailing list