[GRASS-QA] GRASS QA: mmetz |grass.cc | no clones | 0 monsters |4 warnings

[soccerlab.info at gmail.com]

Hello mmetz,

here's a report on your recent grass-SVN change for the revision : 46201 

ANALYSIS 

your changes to files/class/methods/functions : 

*****************************************************************
          File :/raster/r.viewshed/grass.cc
*****************************************************************

          Function
save_grid_to_GRASS(Begins at: 625, Ends at:666)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       7 |       |           OK |         7 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      13 |       |           OK |        13 |
LOC:          |      42 |       |           OK |        42 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 1 values are close to an outlier please consider revising code!


save_vis_elev_to_GRASS(Begins at: 679, Ends at:778)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      12 |     * |      WARNING |        12 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      34 |     * |      WARNING |        34 |
LOC:          |     100 |     * |      WARNING |       100 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 4 values are close to an outlier please consider revising code!


save_io_vis_and_elev_to_GRASS(Begins at: 902, Ends at:1014)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |      14 |     * |      WARNING |        14 |
ParamNBR:     |       4 |     * |      WARNING |         4 |
CalledNBR:    |      36 |     * |      WARNING |        36 |
LOC:          |     113 |     * |      WARNING |       113 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 4 values are close to an outlier please consider revising code!


save_io_visibilitygrid_to_GRASS(Begins at: 825, Ends at:887)
--------------+---------+-------+--------------+-----------+
              |          New Metrics           |Old Metrics|
--------------+---------+-------+--------------+-----------+
Complexity:   |       6 |       |           OK |         6 |
ParamNBR:     |       5 |     * |      WARNING |         5 |
CalledNBR:    |      20 |     * |      WARNING |        20 |
LOC:          |      63 |       |           OK |        63 |
--------------+---------+-------+--------------+-----------+
Conclusion:   | this function is a       WARNING           |
-----------------------------------------------------------+
 at least 2 values are close to an outlier please consider revising code!


Clone analysis:
This file does not contain cloned functions

____________________________________________


Threshold grass key metrics values at Fri May 06 05:54:59 EDT 2011 are:
----------------------+-----------+-----------+-----------+
                      | warning   | middle    | extrem    |
                      | limits    | limits    | limits    |
----------------------+-----------+-----------+-----------+
Complexity (Cyclo):   |         9 |        21 |        33 |
ParamNBR:             |         3 |         6 |         9 |
CalledNBR:            |        17 |        41 |        65 |
LOC:                  |        64 |       145 |       226 |
----------------------+-----------+-----------+-----------+



Measures (see below Web page for details) :
    -Complexity (Cyclo): a complexity index 
    -ParamNBR: number of passed parameters 
    -CalledNBR: number of called functions 
    -LOC: Lines Of Code 
    -Global analysis: based on 21 metrics(the fourth preceding include)

Message interpretation :
    OK : Nothing to say at all
    *  : this is getting close to be out of range, consider revising the code
    ** : this is a baby monster, you should revise this function
    ***: this is a monster, definitely you should revise this function

Conclusion interpretation :
    CORRECT     : if all metrics are situated before warning limits
    WARNING     : if 1 to more metrics are between warning and middle limits
    BABY_MONSTER: if 1 to more metrics are between middle and extreme limits
    MONSTERS    : if 1 to more metrics are in the extreme limits


_______________________________________________
Brought to you by :
	SOftware Cost-effective Change and Evolution Research (SOCCER) laboratory 

Please visite our web site on your project at :
    http://web.soccerlab.polymtl.ca/project-manager/grass-website/index.html