[GRASS-user] r.fillnulls in the latest cvs version doesn't work appropriately

[Martin Landa]

Hi,

2007/2/9, Glynn Clements <glynn at gclements.plus.com>:

[snip]

> > -g implies that you want output. You shouldn't have to add -p as well.
> > I still don't fully understand the logic of why it was changed.

my idea was to make the -g flag more general (i.e. *"how"* to print
not "what" to print).

>
> The idea was that the choices of what to print and how to print it are
> orthogonal.
>
> There should be a fallback so that if you don't specify *what* to
> print, -p should be assumed. However, the code which is meant to do
> this isn't sufficiently general; it treats -g as -gp and -gz as -gzp,
> but doesn't add -p in other cases which might need it.
>
> Rather than having one variable (print_flag), there should be two: one
> for the "what" and another for the "how". If the "what" is empty, it
> should add -p.

I agree,

*what* to print
#define PRINT_REG    0x01
#define PRINT_LL     0x04
#define PRINT_EXTENT 0x08
#define PRINT_CENTER 0x10
#define PRINT_METERS 0x20
#define PRINT_3D     0x40
#define PRINT_MBBOX  0x80

*how* to print:
#define PRINT_SH     0x02

should be OK?

Martin

> --
> Glynn Clements <glynn at gclements.plus.com>
>
> _______________________________________________
> grassuser mailing list
> grassuser at grass.itc.it
> http://grass.itc.it/mailman/listinfo/grassuser
>


-- 
Martin Landa <landa.martin at gmail.com> * http://gama.fsv.cvut.cz/~landa *