[iTowns-dev] Release 2.2.1

Tue Feb 20 06:11:35 PST 2018

Hi!

Yay for this!

I'm gonna nitpick the version number though (TL;DR it should be 3.0 or 2.3):

* 2.2.1 actually represents a patch release[1], but you said you wanted a minor
release. It should indeed be so (so a v2.3), because we added features. Patch
releases (2.2.1) are only for bugfixes.
* *actually* if we really followed semver (which we haven't really done yet), it
should be a 3.0 because there are 2 breaking changes (three.js update is one too).

This is important, because npm follows semver[2]: if you put version ^2.2.0 or
~2.2.0 for itowns in your project package.json, it means you *don't want* to be
broken by upstream changes. If we release a 2.2.1, we will break all these
users. If we release 2.3.0, at least we won't break people who put ~ (the people
that *really* explicitly don't want to be broken, the default being ^).

As a itowns user, being broken by upstream changes should be opt-in, not
opt-out. That's why I would advocate to use semver strictly now that the number
of users is growing and make a major release, which would prevent breaking our
user projects unexpectedly, until the time they will choose to update.

That being said, I understood that some of us think it's less cool in term of
communication*, but at the very least, let's release a 2.3 instead of a 2.2.1.

About the changelogs, some remarks:

* the three.js update should also be in breaking change because it's a peer
dependency for us, and it's actually a major release (in semver, versions of the
form 0.X are actually considered major, see [1]). In practice, they *did* make
some breaking changes.
* I'd put "features" before "bug fixes", but that's juste a personal preference :-)

Thanks for taking care of this Alex!

Augustin Trancart - Oslandia
augustin.trancart at oslandia.com

* I disagree with this because there is no worst communication than breaking
user projects unexpectedly at each release :-)

[1] https://semver.org/
[2] https://docs.npmjs.com/misc/semver

On 20/02/2018 14:14, Alexandre Devaux wrote:
> Hi all!
> 
> Following our 2 months release schedule, we propose a minor release with mainly bug fixes and performance improvements before the next more important release in spring.
> 
> I propose to release v2.2.1 by the end of the week.
> 
> See you soon!
> 
> 
> *Here is the changelog for now:
> 
> ### Breaking change
> 
> The geodesic normal in the center of the tile's geometry is aligned with the mesh's local Z axis.
> Previously, the tiles were not oriented. their local landmark had the same orientation as the world landmark.
> You must take into account the orientation of the tile if you add objects to this tile.
> 
> ### Bug Fixes
> 
> * 3dtiles: fix the sphere bounding volume visualisation in debug mode 
> * 3dtiles: SSE computation for spherical bounding volumes 
> * core: blending with premultiplied color to transparent color layer 
> * core: disable logdepthbuffer if EXT_frag_depth is missing 
> * core: error to update OBBHelper 
> * core: Prevent to subdivide for poor elevation level 
> * core: wrong building 3dTiles's OBB 
> * examples: bad orthographic origin 
> * examples: make examples test friendly 
> * examples: wrong tile matrix limit 
> * gis: possibility to set tiled crs 
> * gis: update proj4 to 2.4.4 
> * GlobeControls: minor debug 
> * protocols: avoid to set points's count at zero 
> * protocols: determine the correct mimeType when using StaticProvider 
> * protocols: stop parsing unnecessarily xbil buffer 
> * protocols: wfs, adapt the mesh transformation with the tile space 
> * protocols: wrong OBB for 3dTile's region 
> * test: !change subdivision count in PLANAR test! 
> * wfs: use bigger integer data type for indices array, for THREE.LineSegments. 
> 
> 
> ### Features
> 
> * 3dtiles: add wireframe support for 3dTiles layer, and add wireframe checkbox to 3dTilesDebugUI, visible in the 3dTiles example 
> * core: add bounding sphere helper in debug mode 
> * core: add event to coordinates helpers 
> * core: update to THREE v89 
> * examples: add gui debug in planar in debug mode only 
> * wfs: Add a debug UI for geometry layer, to change visibility, opacity and toggle wireframe, material size and material linewith 
> 
> 
> ### Performance Improvements
> 
> * core: reduce to obb's highest points for horizon culling 
> * examples: increase performance in filtering the duplicates lines 
> * examples: increase performance to compute altitude line 
> * geometry: avoid useless computation for elevation layers 
> * protocols: increase performance to building features
> 
> 
> 
> --
> Alexandre Devaux
> Chargé d'Etudes et de Recherche
> Laboratoire MATIS, IGN
> Tel: 01 43 98 85 73
> 
> ________________________________________
> De : iTowns-dev [itowns-dev-bounces at lists.osgeo.org] de la part de itowns-dev-request at lists.osgeo.org [itowns-dev-request at lists.osgeo.org]
> Date d'envoi : mardi 6 février 2018 21:00
> À : itowns-dev at lists.osgeo.org
> Objet : iTowns-dev Digest, Vol 18, Issue 1
> 
> Send iTowns-dev mailing list submissions to
>         itowns-dev at lists.osgeo.org
> 
> To subscribe or unsubscribe via the World Wide Web, visit
>         https://lists.osgeo.org/mailman/listinfo/itowns-dev
> or, via email, send a message with subject or body 'help' to
>         itowns-dev-request at lists.osgeo.org
> 
> You can reach the person managing the list at
>         itowns-dev-owner at lists.osgeo.org
> 
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of iTowns-dev digest..."
> 
> 
> Today's Topics:
> 
>    1. iTowns Code Sprint 2018! (Alexandre Devaux)
> 
> 
> ----------------------------------------------------------------------
> 
> Message: 1
> Date: Tue, 6 Feb 2018 17:59:54 +0000
> From: Alexandre Devaux <Alexandre.Devaux at ign.fr>
> To: "itowns-dev at lists.osgeo.org" <itowns-dev at lists.osgeo.org>
> Subject: [iTowns-dev] iTowns Code Sprint 2018!
> Message-ID: <85C671A1D70DA94AB3F4116D5519F757F39FBF0F at mailex2.ign.fr>
> Content-Type: text/plain; charset="us-ascii"
> 
> Hi all!
> 
> 
> The first iTowns Code Sprint of the year will take place from 26 to 28 March 2018, hosted by IGN at IGNFab space (~Paris)
> 
> The page for this event is here :
> 
> https://github.com/iTowns/itowns-project/wiki/CodeSprint4_2018
> 
> Please add you name in the wiki page if you plan to attend, with your favorite topics.
> 
> 
> Glad to see you in person!
> 
> Alexandre
> 
> 
> ------------------------------
> 
> Subject: Digest Footer
> 
> _______________________________________________
> iTowns-dev mailing list
> iTowns-dev at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/itowns-dev
> 
> 
> ------------------------------
> 
> End of iTowns-dev Digest, Vol 18, Issue 1
> *****************************************
> _______________________________________________
> iTowns-dev mailing list
> iTowns-dev at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/itowns-dev
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osgeo.org/pipermail/itowns-dev/attachments/20180220/03ed687b/attachment.sig>