[Liblas-devel] Changeset 1237

[Mateusz Loskot]

Howard Butler wrote:
> 
> On Apr 20, 2009, at 10:17 AM, Mateusz Loskot wrote:
> 
>> Hobu,
>> 
>> "LIBGEOTIFF_VERSION is never defined by any of our configuration
>> stuff. What was the thought here?"
>> 
>> I know LIBGEOTIFF_VERSION is never defined anywhere in libLAS, but
>> it is defined by libgeotiff. Now, if you build libLAS with GDAL
>> (which includes libgeotiff in number of places), but *without*
>> libgeotiff explicitly, libLAS does not compile. This is because:
>> 
> 
> I would note that the only supported configuration of using GDAL 
> *without* an explicit libgeotiff requires a *GDAL source tree*, and
> not just the gdal-config script.  This is because GDAL does not
> install libgeotiff headers as part of its install.  I don't think
> that is the problem in this instance, however.

Perhaps there is no point to try to fix this problem in order to support
liblAS with GDAL but without libgeotiff as it's not a hassle to users to
include libgeotiff support, I think.

So, may be we can just restrict that if user wants GDAL, he must include
libgeotiff to avoid such clashes.

>> 1. This is true #ifndef HAVE_LIBGEOTIFF
>> 
>> 2. GDAL implicitly injects libgeotiff stuff into libLAS space, like
>> 
>> 
>> typedef struct GTIFS *GTIF;
>> 
>> So, we need to have extra test that assures #ifndef HAVE_LIBGEOTIFF
>>  is true only if both conditions are true: 1) libLAS is explicitly 
>> configured with libgeotiff and 2) geotiff header is included.
> 
> 
> ok, I understand now.  reverted http://liblas.org/changeset/1241

OK, but as I've mentioned above, we could figure out how to solve
it on higher level.

Best regards,
-- 
Mateusz Loskot, http://mateusz.loskot.net
Charter Member of OSGeo, http://osgeo.org