[Mapbender-dev] mapbender 2.2.3 on mapbender_dev

[Arnulf Christl]

Michael Schulz wrote:
> Hi,
> 
> think i found the "problem":

Hi,
thanx for the quick solution, you code faster than i can read! :-) I 
added the bug to the Wiki, if this fix solves the problem, so much the 
better. We'll update asap.

Arnulf.

> - in class_wms.php - updateObjInDb - around line 1008:
> 
> if($gui_layer_maxscale[$lastLayer_index]<=$this->objLayer[$i]->layer_maxscale) 
> 
>  $sql .= $gui_layer_maxscale[$lastLayer_index] . ", ";
> } else { $sql .= $this->objLayer[$i]->layer_maxscale . ", ";}
> 
> When the updated wms has no ScaleHint defined, then layer_maxscale is 
> set to 0, thus any gui_layer settings (which are, when set, usually > 0) 
> will be overwritten.
> 
> Maybe we should check two things:
> 1) when no ScaleHint is defined (layer_maxscale==0)
>  or
> 2) when the gui_layer_maxscale is smaller than the Scalehint value
> 
> then use the values from the gui_layer, otherwise use the ScaleHint values:
> 
> if($this->objLayer[$i]->layer_maxscale == 0 || 
> $gui_layer_maxscale[$lastLayer_index]<=$this->objLayer[$i]->layer_maxscale)
>  $sql .= $gui_layer_maxscale[$lastLayer_index] . ", ";
> } else { $sql .= $this->objLayer[$i]->layer_maxscale . ", ";}
> 
> What do you think?
> 
> Michael
> 
> 
> Michael Schulz schrieb:
>> Hi,
>>
>> not sure, maybe this behaviour is already known:
>>
>> After updating a wms, the gui_layers max_scale settings are always set 
>> to 0, instead of taking an already existing value. min_scale settings 
>> are preserved.
>>
>> Greetings from the South (of Germany), Michael
>>
> 
>