[mapguide-commits] r10043 - trunk/MgDev/Web/src/mapadmin

[svn_mapguide at osgeo.org]

Author: jng
Date: 2023-03-30 03:22:01 -0700 (Thu, 30 Mar 2023)
New Revision: 10043

Modified:
   trunk/MgDev/Web/src/mapadmin/resizablepagecomponents.php
Log:
Barring a few deprecated usages of trim (which this commit fixes), the performance report actually does gracefully handles broken layers

Fixes #2297

Modified: trunk/MgDev/Web/src/mapadmin/resizablepagecomponents.php
===================================================================
--- trunk/MgDev/Web/src/mapadmin/resizablepagecomponents.php	2023-03-30 08:35:12 UTC (rev 10042)
+++ trunk/MgDev/Web/src/mapadmin/resizablepagecomponents.php	2023-03-30 10:22:01 UTC (rev 10043)
@@ -2186,7 +2186,7 @@
                 //set different colors for alternate rows and when mouse move over the row it will change color
                 if(0 == $rowNumber%2)
                 {
-                    if(trim($layerProfileData->ErrorMessage) != "")
+                    if($layerProfileData->ErrorMessage != null && trim($layerProfileData->ErrorMessage) != "")
                     {
                        echo '<tr rowselected="false"  errorstatus="1"  onclick="LayerDataTableRowClicked(\''.$layerProfileData->LayerName.'\',this);">',"\n";
                        $backgroundColor = "background-color:#FFFEBB;";
@@ -2198,7 +2198,7 @@
                 }
                 else
                 {
-                    if(trim($layerProfileData->ErrorMessage) != "")
+                    if($layerProfileData->ErrorMessage != null && trim($layerProfileData->ErrorMessage) != "")
                     {
                         echo '<tr rowselected="false" errorstatus="1" onclick="LayerDataTableRowClicked(\''.$layerProfileData->LayerName.'\',this);">',"\n";
                         $backgroundColor = "background-color:#FFFEBB;";
@@ -2405,8 +2405,8 @@
         {
             $hasError = false;
             $onlyLayerError = true;
-            $errorMessage;
-            $errorDetail;
+            $errorMessage = "";
+            $errorDetail = "";
 
             if(isset($this->mapProfileResult->MapProfileData->MapErrorMessage))
             {