[mapguide-internals] ServerRenderingService API bloated

[Trevor Wekel]

Hi UV,

Any "Service" APIs (MgRenderService, MgFeatureService, etc) which are marked
as PUBLISHED_API are automatically swigged to the three implementation
languages (PHP, .Net, Java).  This means any PUBLISHED_API is fair game for
application development.  As such, changes to these API must be managed by
deprecation and subsequent removal in a future release.  I don't know if
this applies to the refactoring work you are proposing.

Thanks,
Trevor 

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org
[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of UV
Sent: Wednesday, March 18, 2009 11:16 PM
To: MapGuide Internals Mail List
Subject: Re: [mapguide-internals] ServerRenderingService API bloated

Thanks! I was wondering.....

I ended up not needing to change any functionality in the 
ServerRenderingService
but had to comment a lot to make sense of it....
It would be a good moment to do a major refactoring session.
I believe the code in there can be made a lot more concise.
There seems to be a lot of code duplication due to even more default 
arguments than the ones mentioned before.....
I think this file is particularly worthwhile and makes me feel I did not 
waste those 2 days staring at 1400 lines C++ code for nothing.

Should I bother?
Will we find anyone for reviewing it.

_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals