[mapguide-internals] ServerRenderingService API bloated

[Traian Stanev]

And we could also start removing old APIs that are no longer used?

Traian


-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Zac Spitzer
Sent: Thursday, March 19, 2009 9:33 AM
To: MapGuide Internals Mail List
Subject: Re: [mapguide-internals] ServerRenderingService API bloated

sounds like a good note to add to the architecture pages on the wiki?

On Fri, Mar 20, 2009 at 12:29 AM, Trevor Wekel
<trevor.wekel at autodesk.com> wrote:
> Nope.  Our modified version of SWIG still does not support default arguments.
>
> ________________________________________
> From: mapguide-internals-bounces at lists.osgeo.org [mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Steve Dang
> Sent: Wednesday, March 18, 2009 10:12 PM
> To: MapGuide Internals Mail List
> Subject: RE: [mapguide-internals] ServerRenderingService API bloated
>
> It's because SWIG did not support default arguments at that time (a few years ago). It may do now.
>
> Steve.
>
> -----Original Message-----
> From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of UV
> Sent: Wednesday, March 18, 2009 9:39 PM
> To: MapGuide Internals Mail List
> Subject: [mapguide-internals] ServerRenderingService API bloated
>
> For clarification:
> Is there a platform with a stupid compiler that does not understand C++
> default arguments?
>
> Or is there another particular reason why the ServerRenderingService
> does not use default arguments  but instead provides 3 method signatures?
>
> Its such a hazzle to read through all this code to find out eventually
> that its simply default arguments which have not been implemented as
> such.....
>
>
>    virtual MgByteReader* RenderMap(MgMap* map,
>                                    MgSelection* selection,
>                                    CREFSTRING format);
>
>    virtual MgByteReader* RenderMap(MgMap* map,
>                                    MgSelection* selection,
>                                    CREFSTRING format,
>                                    bool bKeepSelection);
>
>    virtual MgByteReader* RenderMap(MgMap* map,
>                                    MgSelection* selection,
>                                    CREFSTRING format,
>                                    bool bKeepSelection,
>                                    bool bClip);
>
> instead of
>
>    virtual MgByteReader* RenderMap(MgMap* map,
>                                    MgSelection* selection,
>                                    CREFSTRING format,
>                                    bool bKeepSelection =true ,
>                                    bool bClip=false);
>
>
>
> and again here
>
>    virtual MgByteReader* RenderMap(MgMap* map,
>                                    MgSelection* selection,
>                                    MgCoordinate* center,
>                                    double scale,
>                                    INT32 width,
>                                    INT32 height,
>                                    MgColor* backgroundColor,
>                                    CREFSTRING format);
>
>    virtual MgByteReader* RenderMap(MgMap* map,
>                                    MgSelection* selection,
>                                    MgCoordinate* center,
>                                    double scale,
>                                    INT32 width,
>                                    INT32 height,
>                                    MgColor* backgroundColor,
>                                    CREFSTRING format,
>                                    bool bKeepSelection);
>
>    virtual MgByteReader* RenderMap(MgMap* map,
>                                    MgSelection* selection,
>                                    MgCoordinate* center,
>                                    double scale,
>                                    INT32 width,
>                                    INT32 height,
>                                    MgColor* backgroundColor,
>                                    CREFSTRING format,
>                                    bool bKeepSelection,
>                                    bool bClip);
> instead of
>
> virtual MgByteReader* RenderMap(MgMap* map,
>                                    MgSelection* selection,
>                                    MgCoordinate* center,
>                                    double scale,
>                                    INT32 width,
>                                    INT32 height,
>                                    MgColor* backgroundColor,
>                                    CREFSTRING format,
>                                    bool bKeepSelection = true,
>                                    bool bClip= false);
>
> _______________________________________________
> mapguide-internals mailing list
> mapguide-internals at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapguide-internals
> _______________________________________________
> mapguide-internals mailing list
> mapguide-internals at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapguide-internals_______________________________________________
> mapguide-internals mailing list
> mapguide-internals at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/mapguide-internals
>



-- 
Zac Spitzer -
http://zacster.blogspot.com
+61 405 847 168
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals