[mapguide-internals] RE: Motion: Commit rights for Mars Wu andSpark Liu

Buddy Hu Buddy.Hu at autodesk.com
Mon Aug 1 03:27:07 EDT 2011 

I found another issue. 

"Enumerations: 

enum MgConnectionState
{
    mcsOpen = 0,   /// Connection is still open
    mcsClose,      /// Connection has been closed
    mcsBusy        /// Connection is busy processing other request
};
You will notice that the 1st letter of each word is part of the enumeration value. Also, when using enumerations in your code ALWAYS do the following: 

ConnectionState::mcsOpen
Do NOT do the following: 
mcsOpen
"

Actually, when using enumerations in the code, if we use " ConnectionState::mcsOpen", it will break Linux build. We should use "mcsOpen" instead of " ConnectionState::mcsOpen".
The former usage is not complaint with the C++ standard.

Regards,
Buddy

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Walt Welton-Lair
Sent: Saturday, July 30, 2011 1:34 AM
To: MapGuide Internals Mail List
Subject: RE: [mapguide-internals] RE: Motion: Commit rights for Mars Wu andSpark Liu

Thanks Jon for pointing this out.  That's a mistake in the document.  I've corrected it.

Walt

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jonathan Rizzo
Sent: Friday, July 29, 2011 11:20 AM
To: MapGuide Internals Mail List
Subject: RE: [mapguide-internals] RE: Motion: Commit rights for Mars Wu andSpark Liu

Minor detail, but I was reading over the coding standards and I found an incorrect statement about Try-Catch Statements:

"A try-catch statement may also be followed by finally which is always executed (unless an exception is thrown in the body of an executed catch)."

In fact, finally WILL execute even if an exception is thrown in the body of an executed catch.  I use this technique quite often to "clean up" in the event of an exception but still pass the exception up the stack.  

A minor point, I know, but I thought I should point it out.  
 
Jon

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org
[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Walt Welton-Lair
Sent: Thursday, July 28, 2011 1:20 PM
To: MapGuide Internals Mail List
Subject: [mapguide-internals] RE: Motion: Commit rights for Mars Wu andSpark Liu

As long as they have read and understood the coding standards
(https://trac.osgeo.org/mapguide/wiki/MapGuideCodingStandards) then I support this.

Walt

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org
[mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Bruce Dechant
Sent: Thursday, July 28, 2011 11:56 AM
To: MapGuide Internals Mail List (mapguide-internals at lists.osgeo.org)
Subject: [mapguide-internals] Motion: Commit rights for Mars Wu and Spark Liu

Hi All,



I'd like to propose that we grant subversion commit rights for the MapGuide vault to Mars Wu and Spark Liu.

They are Autodesk developers working in Shanghai, and have made numerous defect fixes and enhancements to the code base over the last few years.


Mars Wu has worked on MGOS for more than 2 years. Here is a summary of the tickets, changesets and RFC he has done:
RFC:

-          MapGuide RFC 96 - QuickPlot solution for both Ajax and Fusion
viewers<http://trac.osgeo.org/mapguide/wiki/MapGuideRfc96>

Tickets:

-          #1412<http://trac.osgeo.org/mapguide/ticket/1412> Implement
RFC 96 - Quick Plot solution for
fusion<http://trac.osgeo.org/mapguide/ticket/1412>

-          #1414<http://trac.osgeo.org/mapguide/ticket/1414> Implement
RFC 96 - Quick Plot solution for
ajax<http://trac.osgeo.org/mapguide/ticket/1414>

-          #1435<http://trac.osgeo.org/mapguide/ticket/1435> IE8: Map
context menu doesn't work after Quick Plot is invoked<http://trac.osgeo.org/mapguide/ticket/1435>

-          #1443<http://trac.osgeo.org/mapguide/ticket/1443>
MgProxyFeatureService::GetCapabilities is using a fixed api version 1.0.0<http://trac.osgeo.org/mapguide/ticket/1443>

-          #1589<http://trac.osgeo.org/mapguide/ticket/1589> Ajax Quick
Plot: Capture box cannot move or rotate when base layers exist<http://trac.osgeo.org/mapguide/ticket/1589>

-          #1757<http://trac.osgeo.org/mapguide/ticket/1757> Quick Ploat
cannot generate map picture in some non-English locale<http://trac.osgeo.org/mapguide/ticket/1757>

-          #1521<http://trac.osgeo.org/mapguide/ticket/1521> Use mouse
wheel to zoom map in the "Digitize"
process<http://trac.osgeo.org/mapguide/ticket/1521>

-          #1539<http://trac.osgeo.org/mapguide/ticket/1539> Script
error when closing IE window / tab with the Quick Plot preview dialog open in Ajax viewer<http://trac.osgeo.org/mapguide/ticket/1539>

-          #1546<http://trac.osgeo.org/mapguide/ticket/1546> Ajax quick
plot enhancements: mouse cursor and event controlling<http://trac.osgeo.org/mapguide/ticket/1546>

-          #1585<http://trac.osgeo.org/mapguide/ticket/1585> Zoom
Rectange doesn't work properly in Ajax
viewer<http://trac.osgeo.org/mapguide/ticket/1585>

Changesets:

-          6012<http://trac.osgeo.org/mapguide/changeset/6012>

-          6010<http://trac.osgeo.org/mapguide/changeset/6010>

-          5509<http://trac.osgeo.org/mapguide/changeset/5509>

-          5507<http://trac.osgeo.org/mapguide/changeset/5507>

-          5501<http://trac.osgeo.org/mapguide/changeset/5501>

-          5430<http://trac.osgeo.org/mapguide/changeset/5430>

-          5512<http://trac.osgeo.org/mapguide/changeset/5512>

-          5411<http://trac.osgeo.org/mapguide/changeset/5411>

-          5394<http://trac.osgeo.org/mapguide/changeset/5394>

-          5152<http://trac.osgeo.org/mapguide/changeset/5152>

-          5132<http://trac.osgeo.org/mapguide/changeset/5132>

-          5098<http://trac.osgeo.org/mapguide/changeset/5098>

-          5097<http://trac.osgeo.org/mapguide/changeset/5097>

-          5095<http://trac.osgeo.org/mapguide/changeset/5095>

-          4091<http://trac.osgeo.org/mapguide/changeset/4091>


Spark has worked on MGOS for more than 2 years. Here is a summary of the tickets, changesets and RFC he has done:

RFC:

-          108 Support
Watermark<http://trac.osgeo.org/mapguide/wiki/MapGuideRfc108>

Tickets:

-          1514 Ctrl+Click can't end digitize LineString in Chrome on
Windows<http://trac.osgeo.org/mapguide/ticket/1514>

-          1527 Rendering fails if the map references to a not-exist
resource<http://trac.osgeo.org/mapguide/ticket/1527>

-          1553 Ctrl+Click at first when "selecting polygon" shows error
message in Safari / Chrome<http://trac.osgeo.org/mapguide/ticket/1553>

-          1605 There is no Serializable attribute for C# wrapper of any
exception class which make the exception can't get across the AppDomain<http://trac.osgeo.org/mapguide/ticket/1605>

-          1728 Fetch size is not set when using command even when
DataCacheSize configuration is
set<http://trac.osgeo.org/mapguide/ticket/1728>

-          1752 Misuse column name instead of column index during data
reader's serialization<http://trac.osgeo.org/mapguide/ticket/1752>

-          1756 ServerFeatureService.DescribeSchemaAsXml will throw
exception when geometry property is inherited from base class<http://trac.osgeo.org/mapguide/ticket/1756>

-          1762 Connect always shows "Cannot parse XML document whose
stream is at end-of-file." when setting
configuration<http://trac.osgeo.org/mapguide/ticket/1762>

Changesets:

-          6011<http://trac.osgeo.org/mapguide/changeset/6011>

-          5999<http://trac.osgeo.org/mapguide/changeset/5999>

-          5988<http://trac.osgeo.org/mapguide/changeset/5988>

-          5949<http://trac.osgeo.org/mapguide/changeset/5949>

-          5557<http://trac.osgeo.org/mapguide/changeset/5557>

-          5556<http://trac.osgeo.org/mapguide/changeset/5556>

-          5458<http://trac.osgeo.org/mapguide/changeset/5458>

-          5444<http://trac.osgeo.org/mapguide/changeset/5444>

-          5393<http://trac.osgeo.org/mapguide/changeset/5393>

-          5367<http://trac.osgeo.org/mapguide/changeset/5367>

-          5366<http://trac.osgeo.org/mapguide/changeset/5366>

-          5365<http://trac.osgeo.org/mapguide/changeset/5365>

-          5302<http://trac.osgeo.org/mapguide/changeset/5302>

-          5290<http://trac.osgeo.org/mapguide/changeset/5290>

-          5237<http://trac.osgeo.org/mapguide/changeset/5237>

-          5220<http://trac.osgeo.org/mapguide/changeset/5220>

-          5168<http://trac.osgeo.org/mapguide/changeset/5168>

-          5139<http://trac.osgeo.org/mapguide/changeset/5139>

-          4461<http://trac.osgeo.org/mapguide/changeset/4461>




I would like to motion for a vote on giving Mars Wu and Spark Liu commit rights to the MapGuide vault.



+1 Bruce



Thanks,

Bruce
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals

This electronic transmission may contain confidential, proprietary or privileged information.  No confidentiality or privilege is intended to be waived or lost by erroneous transmission of this message.  If you receive this message in error, please notify the sender immediately by return email and delete this message from your system.  Disclosure, use, distribution or copying of this message, any attachments thereto or their contents is strictly prohibited. 

_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals

More information about the mapguide-internals mailing list