[mapguide-internals] Code review request: remove unnecessary loop to improve the performance

Buddy Hu Buddy.Hu at autodesk.com
Mon Aug 1 03:31:13 EDT 2011


Hi lists,

I add an new patch "Remove-loop.patch" for you review in http://trac.osgeo.org/mapguide/ticket/1069 to improve the server performance.


"I reopen this ticket because I found the revision #4191 can't improve the performance, but decline the server performance.The reason is:

The new server API GetResourceContents() is used to reduce the request between web and server. However in server internal, we shouldn't invoke this API to get resource contents. There are overhead to prepare the layerIds and to get the these contents. You can see ImprovePerformance.patch, in MappingUtil.cpp/LegendUtil.cpp, there are some for statements are introduced. This will decline the performance.

So we should revert the revision #4191."

Please add your comments!

Buddy


More information about the mapguide-internals mailing list