[mapguide-internals] Patch for ticket 2379 (GETMAPLEGENDIMAGE does not handle ShowInLegend style setting and multi-style scale ranges properly)

[Walt Welton-Lair]

Hi Jackie,

Two things I noticed:

1/ Imagine you have a FeatureTypeStyleCollection with a themed PointTypeStyle and an unthemed CompositeTypeStyle.  The peek-ahead code gives the CompositeTypeStyle precedence, so nTotalRules is 1 and we just render the unthemed CompositeTypeStyle.  Now change it so you have a themed PointTypeStyle and a themed CompositeTypeStyle.  We have nTotalRules > 1, so we enter the 'layer is themed' section.  It iterates over the FeatureTypeStyleCollection and renders all rules for ALL FeatureTypeStyles.  So in the first example the legend reflects that the CompositeTypeStyle has precedence, but in the second example it doesn't.  Should it?

2/ There's a check for y < bottomLimit inside the Rule loop.  If true we break out of the loop, and then continue processing the next FeatureTypeStyle.  The y < bottomLimit check will be hit again, so no more rendering happens (as required).  We could add another y < bottomLimit check after the Rule loop and immediately break out of the FeatureTypeStyle loop.

Walt

-----Original Message-----
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jackie Ng
Sent: Thursday, November 14, 2013 4:57 AM
To: mapguide-internals at lists.osgeo.org
Subject: Re: [mapguide-internals] Patch for ticket 2379 (GETMAPLEGENDIMAGE does not handle ShowInLegend style setting and multi-style scale ranges properly)

I've attached a revised patch for review
(http://trac.osgeo.org/mapguide/attachment/ticket/2379/2379_v2.patch)

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Patch-for-ticket-2379-GETMAPLEGENDIMAGE-does-not-handle-ShowInLegend-style-setting-and-multi-style-s-tp5089060p5089090.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
_______________________________________________
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-internals