[mapguide-internals] Patch for ticket 2379 (GETMAPLEGENDIMAGE does not handle ShowInLegend style setting and multi-style scale ranges properly)
walt.welton-lair at autodesk.com
Fri Nov 15 06:59:50 PST 2013
I see one more issue. If you have multiple CompositeTypeStyles in the collection and the first is unthemed, then the code will only populate the legend with this first one. In the peek-ahead code, as soon as it finds the first CompositeTypeStyle it sets nRuleCount based on that FTS and breaks out of the loop. So in this example bThemed ends up false.
Your updated code handles the case of multiple non-CompositeTypeStyles correctly. It needs the same behavior for multiple CompositeTypeStyles.
From: mapguide-internals-bounces at lists.osgeo.org [mailto:mapguide-internals-bounces at lists.osgeo.org] On Behalf Of Jackie Ng
Sent: Thursday, November 14, 2013 10:49 PM
To: mapguide-internals at lists.osgeo.org
Subject: Re: [mapguide-internals] Patch for ticket 2379 (GETMAPLEGENDIMAGE does not handle ShowInLegend style setting and multi-style scale ranges properly)
I've added a third version of the patch for review
It adds an extra boolean variable to determine if a composite style was found in the peek-ahead code, and uses this variable to skip over any non-composite type styles in the themed code path.
And also includes the extra loop break after the rule loop as you suggested.
View this message in context: http://osgeo-org.1560.x6.nabble.com/Patch-for-ticket-2379-GETMAPLEGENDIMAGE-does-not-handle-ShowInLegend-style-setting-and-multi-style-s-tp5089060p5089262.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
mapguide-internals mailing list
mapguide-internals at lists.osgeo.org
More information about the mapguide-internals