[mapguide-users] Urgent MGOS stability problem

[Jason Birch]

In case Haris isn't around I'll post my totally uninformed understanding of the problem...

One was a huge memory leak, found and fixed independently in 2.1.

The second was (I think) writing to uninitialized variable or something.  I'm attaching a patch based on some info I got from Haris (I wanted to apply this to my 2.1 builds to see what it did), but I did it so it may be incorrect.  I believe that he also changed code slightly to only do the non-paletted operations if required.

This hasn't been submitted yet because it's still being tested here and at Haris' customer site.  There may be other problems, but possibly these are in the FDO layer not MapGuide.
 
Jason

-----Original Message-----
From: mapguide-users-bounces at lists.osgeo.org [mailto:mapguide-users-bounces at lists.osgeo.org] On Behalf Of Trevor Wekel
Sent: March-20-09 11:57 AM
To: MapGuide Users Mail List
Subject: RE: [mapguide-users] Urgent MGOS stability problem

Hi Haris,

Could you post the code patch for your changes to MgStylization.dll?  I am very curious.

Thanks,
Trevor

-----Original Message-----
From: Haris Kurtagic [mailto:haris at sl-king.com] 
Sent: Friday, March 20, 2009 7:25 AM
To: MapGuide Users Mail List
Subject: RE: [mapguide-users] Urgent MGOS stability problem

We have simillar problems on customer site. We found that we have
problems with rasters.
Same problems are with MG ENT and with MGOS and also not working
correclty using either Autodesk or OsGeo raster provider.

Up to now, I have found 2 bugs in MG server code. I fixed those bugs and
It works better for us now but still not completly ok (latest version
yet to be tested at customer site).

If you want to try it, here is file to replace:
http://www.sl-king.com/download/MgStylization.rar
Unrar and replace over your existing file.

 
Haris


-----Original Message-----
From: mapguide-users-bounces at lists.osgeo.org
[mailto:mapguide-users-bounces at lists.osgeo.org] On Behalf Of marius.360
Sent: Friday, March 20, 2009 12:44 PM
To: mapguide-users at lists.osgeo.org
Subject: [mapguide-users] Urgent MGOS stability problem


Hi all,

This is regarding Ticket #726 and Ticket #480.

We have a MGOS 2.0.2, .net and IIS 6.0 site running on windows server
2003,
spatial data residing in Oracle 10gR2 with the latest King.oracle
provider
and displayed with the DWF viewer. 
Our map consists of 16 layer groups, and 122 layers that are authored so
that the minimum layers are displaying by default. There is one raster
layer, displaying mrSID's. Most of the big layers read from sdf to
increase
performance, and some layers read from oracle using the king.oracle
provider. A few of these oracle layers read from views. Everything
displays
with reasonable speed. 
The user environment has a potential of about 400 users, but they won't
ever
be connected at one time. We can expect at most 100 users accessing the
site
at one time.

The problem we have is that mgos used to crash regularly, about once a
day.
After a few posts on the userlists it was thought that our raster layer
might be causing the problem. I have turned of the raster layer to
prevent
this untill a fix is found, or a later version. Since then the crashes
have
decreased a lot, now it only occurs about once a week, much less than
before. Also from a previous post of mine, someone mentioned that I
might be
affected but the bugs found in Ticket #726 and Ticket #480.

Can anyone please comment on if this seems likely, or if there might be
some
other problems? Also, will these bugs be present in Mapguide Enterprise?
If
no solution is found, we will move over to enterprise, but if this bug
is
still present there then it won't be the answer.

Please let me know if more Info is required, I will gladly provide it.
Any
inputs will be welcome, or any hints and tips regarding the overall
situation.

Kind Regards,

Marius.
-- 
View this message in context:
http://n2.nabble.com/Urgent-MGOS-stability-problem-tp2508362p2508362.htm
l
Sent from the MapGuide Users mailing list archive at Nabble.com.

_______________________________________________
mapguide-users mailing list
mapguide-users at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-users

_______________________________________________
mapguide-users mailing list
mapguide-users at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/mapguide-users
-------------- next part --------------
Index: GridData.cpp
===================================================================
--- GridData.cpp	(revision 3740)
+++ GridData.cpp	(working copy)
@@ -513,17 +513,24 @@
                     };
                 };
 
+/*
                 //FdoPtr<FdoByteArray> palArray = palLOB->GetData();
                 RS_InputStream* pStream = pRaster->GetPalette();
                 void* pPalBuf = NULL;
                 pStream->read(pPalBuf, pStream->available());
                 //RgbColor* palette = reinterpret_cast<RgbColor*>(palArray->GetData());
                 RgbColor* palette = reinterpret_cast<RgbColor*>(pPalBuf);
+*/
 
                 unsigned int color;
                 unsigned int pos;
                 if (bitPerPixel >= 8)
                 {
+                    RS_InputStream* pStream = pRaster->GetPalette();
+                    FdoByte* pPalBuf = new FdoByte[pStream->available()];
+                    pStream->read(pPalBuf, pStream->available());
+                    RgbColor* palette = reinterpret_cast<RgbColor*>(pPalBuf);
+
                     for (unsigned long y = 0; y < actualRows; ++y)
                     {
                         //FireOnStepQuery();
@@ -549,6 +556,9 @@
                             pGisBand->SetValue(colStartPos + x, rowStartPos + y, Band::UnsignedInt32, &color );
                         }
                     }
+                    
+                    delete []pPalBuf;
+                    
                 }
                 else
                 {